Re: [PATCH 6/9] Add traffic forwarding via RTP to remote application

[Holger Hans Peter Freyther]

On Fri, Apr 18, 2014 at 12:22:31PM +0200, Andreas Eversberg wrote:


>       S_LCHAN_HANDOVER_FAIL,          /* 04.08 Handover Failed */
>       S_LCHAN_HANDOVER_DETECT,        /* 08.58 Handover Detect */
>       S_LCHAN_MEAS_REP,               /* 08.58 Measurement Report */
> +     S_LCHAN_RTP_SOCKET_FREE,

Use the opportunity to write a bit of information here? Or maybe
just use S_CHALLOC_FREED to free rtp_socket and introduce a
S_CHALLOC_RESET to do it in the later case?

> +             struct lchan_signal_data sig;

please either use memset on sign or the 0 initializer of C99.

> diff --git a/openbsc/src/libmsc/rtp_proxy.c b/openbsc/src/libmsc/rtp_proxy.c

Please use the -M option on git format-patch/send-email to properly
detect renames.



thanks
        holger