On Fri, Oct 03, 2014 at 11:11:55AM +0200, Jan Engelhardt wrote:
Dear Jan,
> >my position has not changed. The --disable-talloc is an option for
> >Embedded Firmware (e.g. OsmocomBB) that do not want to include talloc.
> >It is not for people that want to use their distributions talloc.
>
> The software does not fully build with --disable-talloc,
> how could it be of use?
> (It's possible yes, by sneaking in the talloc symbols in
> another way, e.g. through a patched libc...)
--disable-talloc (and other feature flags) is a special purpose option
to reduce the size of the library (e.g. for usage on the OsmocomBB
firmware). It is not expected that on a library with reduced functionality
the remaining code will build.
We had this discussion in 02.2013 and my position has not changed. I agree
that we should not have a copy of talloc in our codebase and should rely
on the system to provide it. There should not be a osmocom/core/talloc.h
and all projects that use talloc should check for the talloc.pc file.
Your patch is not moving us in that direction and opens a new can
of worms (potential ABI/API incompats, assuming that libtalloc can
be found in the library paths passed to the linker, etc.)
kind regards
holger
