On Sat, Nov 15, 2014 at 02:03:31PM -0600, Ruben Pollan wrote:
> Good morning,

Good Evening!

> You are right, this is not great. After discussing it with ciaby we decided 
> that 
> might make more sense to do something like:
> 
> snprintf(sms_str, len, "%s IMSI: %s Token: %08X Ext: %s"
>                auth_token_sms_text, subscr->imsi, token, subscr->extension);
> 
> So the auth_token_sms_text don't have any placeholders it's just the 
> introductory text. What do you think?

Yes, it would be missing i18n.. but so does the entire OpenBSC
codebase. I would really prefer to set this through the VTY than
to put it into a database. Using ".TEXT" inside the VTY command
string you can match more than just a single word. I think '%'
is still not possible though.


holger

Reply via email to