On 07/14/2015 01:32 PM, Holger Hans Peter Freyther wrote:
> From: Holger Hans Peter Freyther <[email protected]>
> 
> In case foreign simcards are used we can not do authentication
> and ciphering. In case a TMSI is re-used too early and we do
> page using TMSI we can't know which of the two MS is responding
> to us. We could change the "secure channel" routine to ask for
> the IMSI and only then stop the paging.
> 
> As we don't have ciphering there is not much use in using the
> TMSI. Add a mode "no assign-tmsi" that will not assign the TMSI
> during LU. Now CM Service Request and Paging Response  will
> work using the IMSI. There can't be a clash with that.
[...]
>  static int config_write_nitb(struct vty *vty)
>  {
>       struct gsm_network *gsmnet = gsmnet_from_vty(vty);
>       vty_out(vty, "nitb%s", VTY_NEWLINE);
>       vty_out(vty, " %ssubscriber-create-on-demand%s",
>               gsmnet->create_subscriber ? "" : "no ", VTY_NEWLINE);
> +     vty_out(vty, " %suse-tmsi%s",
> +             gsmnet->avoid_tmsi ? "no" : "", VTY_NEWLINE);
>       return CMD_SUCCESS;
>  }
This part is broken. Whenever you try to set it it will put "use-tmsi"
instead of "assign-tmsi". The moment you save it and restart, it barfs
on the "use-tmsi" line. If you put a no in front, it will be saved as
"nouse-tmsi". I fixed both problems with the attached patch.
Cheers

Ciaby


From 255e7c09f243f61e9381ad7702cbfbe3cd1b9f34 Mon Sep 17 00:00:00 2001
From: Ciaby <[email protected]>
Date: Tue, 28 Jul 2015 08:11:29 -0500
Subject: [PATCH] nitb: Rename "use-tmsi" into "assign-tmsi", add a missing
 space after "no"

---
 openbsc/src/libmsc/vty_interface_layer3.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c
index 3c33ffc..1515aea 100644
--- a/openbsc/src/libmsc/vty_interface_layer3.c
+++ b/openbsc/src/libmsc/vty_interface_layer3.c
@@ -1061,8 +1061,8 @@ static int config_write_nitb(struct vty *vty)
 	vty_out(vty, "nitb%s", VTY_NEWLINE);
 	vty_out(vty, " %ssubscriber-create-on-demand%s",
 		gsmnet->create_subscriber ? "" : "no ", VTY_NEWLINE);
-	vty_out(vty, " %suse-tmsi%s",
-		gsmnet->avoid_tmsi ? "no" : "", VTY_NEWLINE);
+	vty_out(vty, " %sassign-tmsi%s",
+		gsmnet->avoid_tmsi ? "no " : "", VTY_NEWLINE);
 	return CMD_SUCCESS;
 }
 
-- 
1.7.9.5

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to