Hello OpenBSC, see attached patches: one added configure script requirement and two entirely cosmetic tweaks.
~Neels
From 0e3a6631bd5f17b2878bc1863a7d9aa1d3cd846b Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr <[email protected]> Date: Tue, 15 Sep 2015 11:39:47 +0200 Subject: [PATCH 1/3] openbsc/configure.ac: check for pcap/pcap.h. The build process requires pcap/pcap.h in openbsc/src/utils/meas_pcap2db.c, but the configure script did not check for that file. --- openbsc/configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/openbsc/configure.ac b/openbsc/configure.ac index 0ebb041..78302dd 100644 --- a/openbsc/configure.ac +++ b/openbsc/configure.ac @@ -88,6 +88,7 @@ dnl checks for header files AC_HEADER_STDC AC_CHECK_HEADERS(dahdi/user.h,,AC_MSG_WARN(DAHDI input driver will not be built)) AC_CHECK_HEADERS(dbi/dbd.h,,AC_MSG_ERROR(DBI library is not installed)) +AC_CHECK_HEADERS(pcap/pcap.h,,AC_MSG_ERROR(PCAP library is not installed)) found_cdk=yes AC_CHECK_HEADERS(cdk/cdk.h,,found_cdk=no) -- 2.1.4
From 7d2cfe04e8ff9b6da27dc5d9d8267e89755a1205 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr <[email protected]> Date: Tue, 15 Sep 2015 11:43:32 +0200 Subject: [PATCH 2/3] Remove empty README. This README's content has moved to openbsc/README. This is just an empty file now. --- README | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 README diff --git a/README b/README deleted file mode 100644 index e69de29..0000000 -- 2.1.4
From a1c2f64895ec99eaf8bdd1d3d97324ea3a96b225 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr <[email protected]> Date: Tue, 15 Sep 2015 11:50:50 +0200 Subject: [PATCH 3/3] osmo-nitb: obsess about --help formatting. Make every line use same punctuation style ('.' at the end and start in caps). Insert spaces to have all help texts in a column. --- openbsc/src/osmo-nitb/bsc_hack.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/openbsc/src/osmo-nitb/bsc_hack.c b/openbsc/src/osmo-nitb/bsc_hack.c index 3517899..75229b9 100644 --- a/openbsc/src/osmo-nitb/bsc_hack.c +++ b/openbsc/src/osmo-nitb/bsc_hack.c @@ -91,20 +91,20 @@ static void print_usage() static void print_help() { printf(" Some useful help...\n"); - printf(" -h --help this text\n"); - printf(" -d option --debug=DRLL:DCC:DMM:DRR:DRSL:DNM enable debugging\n"); - printf(" -D --daemonize Fork the process into a background daemon\n"); - printf(" -c --config-file filename The config file to use.\n"); + printf(" -h --help This text.\n"); + printf(" -d option --debug=DRLL:DCC:DMM:DRR:DRSL:DNM Enable debugging.\n"); + printf(" -D --daemonize Fork the process into a background daemon.\n"); + printf(" -c --config-file filename The config file to use.\n"); printf(" -s --disable-color\n"); - printf(" -l --database db-name The database to use\n"); - printf(" -a --authorize-everyone. Authorize every new subscriber. Dangerous!.\n"); - printf(" -T --timestamp Prefix every log line with a timestamp\n"); - printf(" -V --version. Print the version of OpenBSC.\n"); - printf(" -P --rtp-proxy Enable the RTP Proxy code inside OpenBSC\n"); - printf(" -e --log-level number. Set a global loglevel.\n"); - printf(" -m --mncc-sock Disable built-in MNCC handler and offer socket\n"); - printf(" -C --no-dbcounter Disable regular syncing of counters to database\n"); - printf(" -r --rf-ctl NAME. A unix domain socket to listen for cmds.\n"); + printf(" -l --database db-name The database to use.\n"); + printf(" -a --authorize-everyone Authorize every new subscriber. Dangerous!\n"); + printf(" -T --timestamp Prefix every log line with a timestamp.\n"); + printf(" -V --version Print the version of OpenBSC.\n"); + printf(" -P --rtp-proxy Enable the RTP Proxy code inside OpenBSC.\n"); + printf(" -e --log-level number Set a global loglevel.\n"); + printf(" -m --mncc-sock Disable built-in MNCC handler and offer socket.\n"); + printf(" -C --no-dbcounter Disable regular syncing of counters to database.\n"); + printf(" -r --rf-ctl NAME A unix domain socket to listen for cmds.\n"); } static void handle_options(int argc, char **argv) -- 2.1.4
signature.asc
Description: Digital signature
