> On 29 Feb 2016, at 01:08, Neels Hofmeyr <[email protected]> wrote: > > > > So we have the API talking about length "in octets" while the implementation > clearly employs septet length. > > Fixing the implementation to match the API doc would break binary > compatibility. I should probably fix the API doc to match that weird > implementation, but it nags and hurts a little. > > Any opinions?
please fix the API comment. IIRC there are several fields in encoded messages where the length is passed as septets. E.g. for SMS the last 7 bits of an octet might not belong to the text anymore. Passing the number of septets avoids this issue. holger
