Re: [PATCH 3/3] mgcp: Remove the old MGCP based transcoding interface

[Neels Hofmeyr]

On Tue, Mar 08, 2016 at 06:35:20PM +0100, Holger Hans Peter Freyther wrote:
> -DEFUN(cfg_mgcp_rtp_transcoder_range,
> +DEFUN_DEPRECATED(cfg_mgcp_rtp_transcoder_range,
>        cfg_mgcp_rtp_transcoder_range_cmd,
>        "rtp transcoder-range <0-65534> <0-65534>",
>        RTP_STR "Range of ports to use for the Transcoder\n"
>        RANGE_START_STR RANGE_END_STR)
>  {
> -     parse_range(&g_cfg->transcoder_ports, argv);
> -     return CMD_SUCCESS;
> +     vty_out(vty, "%% functionality has been removed.%s", VTY_NEWLINE);
> +     return CMD_WARNING;
>  }

Imagining a config file with rtp transcoder config items, startup will
just say

  % functionality has been removed.

without an indication which of the commands caused the message.
Life would then be simpler if the message said

  % rtp transcoder has been removed.

(5 times)

~Neels

signature.asc
Description: Digital signature