Hi Max, I have already merged the patch, but now have one more comment that should definitely be addressed ASAP:
On Thu, Mar 17, 2016 at 11:51:09AM +0100, [email protected] wrote: > +struct earfcn { 1) this misses the osmo_ prefix which must be used for all new data types and symbols in the libraries 2) it is not just an EARFCN (which is an integer), but it is actually some SI-specific EARFCN parameters. So please let's give it a proper name. like osmo_earfcn_meas_pars (for measurement parameters) or the like. Please provide a follow-up patch quickly so we can resolve this before any users rely on the old naming. Thanks. Regards, Harald -- - Harald Welte <[email protected]> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
