Hi Max, I disagree with this patch. We don't want to make all warnings quiet at all cost. If that was the goal, we could simply disable compiler warnings and go ahead.
The point is that the SUA code is incomplete, and I prefer to have a warning about it until it gets properly fixed. This: On Fri, Apr 08, 2016 at 12:46:05AM +0200, Neels Hofmeyr wrote: > - cause = xua_msg_get_u32(xua, SUA_IEI_CAUSE); > + /* TODO evaluate cause: > + * cause = xua_msg_get_u32(xua, SUA_IEI_CAUSE); */ will just mean that we all forget about having to fix it. -- - Harald Welte <[email protected]> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
