Patch Set 2: (5 comments)
Argh. I just noticed an issue with the libosmocore change. I will need to revert it. We want to be able to use old OpenBSC code against newer libosmocore and this can only be done... if int->string->int code is in libosmocore. :( https://gerrit.osmocom.org/#/c/63/2/openbsc/include/openbsc/gsm_subscriber.h File openbsc/include/openbsc/gsm_subscriber.h: PS2, Line 16: define We need to move this to libosmocore. I just noticed that by accepting the change in libosmocore but not this one. We actually broke the parsing of TMSIs and LUs and CM Service Request.. We need to have both in libosmocore. https://gerrit.osmocom.org/#/c/63/2/openbsc/src/libmsc/db.c File openbsc/src/libmsc/db.c: Line 216: LOGP(DDB, LOGL_NOTICE, "Migration complete.\n"); Why this hunk? Line 237: sms->id = dbi_result_get_ulonglong(result, "id"); Why that? I mean v3 is old. We should not see this right now? Line 376: return -EINVAL; Please put that in a separate commit Line 417: "INSERT INTO Subscriber " You rely on sqlite doing type conversion from string to number here? -- To view, visit https://gerrit.osmocom.org/63 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I518c441f11f234b8f34ede5b76671049f06b6599 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
