On Mon, Jul 25, 2016 at 08:40:37PM +0800, Holger Freyther wrote: > > > On 25 Jul 2016, at 18:22, Neels Hofmeyr <[email protected]> wrote: > > > > I just came across this compiler warning: > > > > l1sap.c: In function 'gsmtap_ph_rach': > > l1sap.c:291:8: warning: assignment from incompatible pointer type [enabled > > by default] > > *data = &l1sap->u.rach_ind.ra; > > ^ > > okay, I reviewed the patch that adds 11bit support for the sysmobts but > l1sap.c is not addressed. Shall we revert the 11bit l1sap change for now or > wait?
This "only" concerns gsmtap. Given the lengthy course of those patches, I'd give it some time and not add frustration with a revert... Bhagarva, are you reading this, and could you add gsmtap capability for 11 bit soon? > PS: If we would disable the doxygen warnings and remove -Wall when compiling > the dependencies the amount of warnings would go down and we might find such > things earlier? +1 for disabling doxygen warnings (or >/dev/null 2>&1 even) Otherwise, the way I notice warnings is mostly by running ':make' in vim and browsing the warnings. We don't have that many warnings with -Wall, do we? Most of them are usually '#warning' or deprecation warnings. I'd keep -Wall. ~Neels -- - Neels Hofmeyr <[email protected]> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
signature.asc
Description: Digital signature
