There are other things like DTX and PTCCH which prevent me from working on this right now. As I've explained in the ticket I don't think that reverting this commit is urgent but feel free to add your comments to the ticket, send revert patch to gerrit, raise ticket urgency with Harald etc. etc.
On 10/20/2016 01:35 PM, Neels Hofmeyr wrote: > On Wed, Oct 19, 2016 at 03:03:04PM +0200, Max wrote: >> I've made ticket for this: https://projects.osmocom.org/issues/1829 > So you would like to first write unit tests and so on until these warnings > will > go away. How urgently will you pursue this? Are you actively working on it? > > I will locally revert the constify patch to avoid the warnings flood. Which > adds the need for rebase for every pull in libosmocore. I have some of those > already related to the 3G branches: it's cumbersome. > > Can we please commit the revert on master and re-commit the constify when > OS#1829 is resolved? > > ~Neels > -- Max Suraev <[email protected]> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
