Hi Holger, On Sat, Sep 15, 2018 at 08:35:48AM +0100, Holger Freyther wrote: > I recently stumbled across shellcheck[1] and think we should make it a goal > that our shell scripts don't > produce errors/warnings with it.
definitely a good idea! > What do you think? My approach would be: > > * Install shellcheck into our build containers > * Run them and provide warnings > * Fix them over time and on new code > * Make CI fail with failures sounds like a good plan. I suppose any changes to the build slaves would be performed via our ansible playbooks to ensure we can replicate the setup at any point in the future, as needed. Thanks! -- - Harald Welte <[email protected]> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
