Should we now put copyright comments in header files as well?
re 
https://gerrit.osmocom.org/c/osmo-msc/+/11642/3/include/osmocom/msc/sgs_iface.h#2

When I see structs containing talloc'd char*, should I generally give code
review to use fixed char arrays instead? I think it ends up being simpler
semantically as well as better in terms of mem allocation. Right?  e.g.
https://gerrit.osmocom.org/c/osmo-msc/+/11642/30/include/osmocom/msc/sgs_server.h#18
and #21

Thanks for your opinions...

~N

Attachment: signature.asc
Description: PGP signature

Reply via email to