Hello,

in the changes to `src/gb/gprs_ns2_vc_fsm.c` (see subject line), I found a few lines that puzzle me (as a newbie to the Osmocom codebase(s), they look like an error to me):


```

        case GPRS_NS2_EV_REQ_OM_UNBLOCK:

                /* vty cmd: unblock*/
                if (!priv->om_blocked)
                        return;
                priv->om_blocked = false;
                if (fi->state == GPRS_NS2_ST_BLOCKED)
                        osmo_fsm_inst_state_chg(fi, GPRS_NS2_ST_BLOCKED, nsi->timeout[NS_TOUT_TNS_BLOCK], 0);
                break;

```

To me it seems like the 'new_state' argument should be `GPRS_NS2_ST_UNBLOCKED`, since we are trying to unblock (that's what the `event` case says here from my understanding).

What am I misunderstanding here?

Cheers,

Alex

Reply via email to