Hi Mychaela,
sorry for the late response...
On Thu, Mar 09, 2023 at 06:30:43PM -0800, Mychaela Falconia wrote:
> Adding the just-described SID logic to osmo_rtp2trau() would be quite
> easy:
>
> 1) Add a function to libosmocore that would be just like
> osmo_fr_check_sid(), but for EFR;
>
> 2) Add the SID logic to osmo_rtp2trau() in libosmo-abis, using
> osmo_fr_check_sid() for FR1 and the new function for EFR.
>
> I would be happy to submit Gerrit patches doing 1 and 2 above, *iff*
> there is at least one person on Earth (OP or anyone else) who would
> find them useful.
Thanks for your offer.
I hereby declare that I am a person on Earth and would find it useful.
> * In the DL direction, I do see a problem in osmo_rtp2trau() that can
> be fixed with a patch. GSM 08.60 sections 4.5.2 and 4.5.3 say: "If no
> speech is received from the MSC side of the interface (downlink
> direction), idle speech frames shall be transferred instead of speech
> frames." - however, the code in osmo_rtp2trau() fails to obey this
> requirement, instead it sends TRAU speech frames with garbage payload
> when the rtp_len argument to the function is 0, indicating missing
> speech data. Once again, I would be happy to produce a patch fixing
> this bug if someone (OP or anyone else) would like to see one.
Likewise, I would like to see a patch for that.
Thanks,
Harald
--
- Harald Welte <[email protected]> https://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
