On 01-08-28 10:20:50 CEST, Uwe Gansert wrote:
> Hi,
> 
> a patch to avoid another warning in OpenSSL.pm
> 
> --- /usr/lib/perl5/site_perl/5.6.0/OpenCA/OpenSSL.pm    Tue Aug 28 10:15:08 2001
> +++ OpenSSL.pm  Tue Aug 28 10:18:23 2001
> @@ -686,7 +686,7 @@
>                  $command .= "-engine $engine ";
>          }
>  
> -       if ( $outfile eq "" ){
> +       if ( not(defined($outfile)) || $outfile eq "" ){
>                 $tmpfile = $self->{tmpDir} . "/${$}_crl.tmp";
>         } else {
>                 $tmpfile = $outfile;

how about initializing the variable once instead of inflating (and IMHO
uglyfying) the code everywhere...?

or, instead of initializing, using the definedness of a variable as the
exceptional value, instead of the empty value?

rj

_______________________________________________
OpenCA-Devel mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/openca-devel

Reply via email to