Michael Bell wrote:

Rob Thorne wrote:

I've played around a bit with the autotool scripts, and may have a better approach for building on the RedHat family of distributions.


You are free to choose the best option. We only create working versions for all Unix. If you start using packages then there is no standard.

My goal was to patch in such a way that it would work for any Unix. There is nothing package specific in the patch. I did, however, add the ability of configure to recognize the presence of the pkg-config utility and make use of it if it is available. Since I'm guarding the use of the PKG_CHECK_MODULES in an "ifdef()" block, if a developer does not use pkg-config, my changes will be completely invisible to him: my changes will expand to nothing.



My impression is that there are other distributions and platforms that use pkg-config as well, so my patch should build correctly on those as well.

If pkg-config is not present, configure will use the 'openssl_prefix' variable as it already does.


Sorry but this is not really correct. Many people use old distributions with packaged OpenSSL 0.9.6 and manually compiled and installed OpenSSL 0.9.7 in /usr/local/ssl/. If you only test for the presence of an OpenSSL which was configured by pkg-config then you cannot build OpenCA because OpenCA requires OpenSSL 0.9.7. openssl-prefix must override pkg-config.

This is an easy change for me to make. It's important to point out, however, that openssl-prefix does not really do what you need it to do: it assumes that OpenSSL links in a very simple way. The reason we broke on RedHat was that specifying the prefix was not enough; the needed flags for a copy of OpenSSL that links Kerberos doesn't fit into your current script.


What you really want is to make it possible to specifiy the CFLAG and LIBS options for linking OpenSSL. This would also solve the general problem.


The patch tries to compile OpenCA with OpenSSL 0.9.6 if there is a packaged version of OpenSSL 0.9.6 and this is wrong. I can only apply your patch if it always enforces --with-openssl-prefix if it is set.

Again, this is an easy change to make.



The fix also moves the logic for setting the positions of the OpenSSL libraries from a number of Makefile.am files into the corresponding configure.in files, and fixes a small problem with Makefile.devel where it did not call aclocal at the top level.


The moving of the openssl references makes the makefiles nicer. So it is ok. Why do you want to run aclocal before autoconf at toplevel?

The call to aclocal is actually necessary. aclocal will make sure that any macro that the autotools know about will be correctly expanded. Try adding a new macro to the top level configure.in. You'll see that it is not expanded correctly unless you make that initial call to aclocal.



Can you please try to build a new patch which always respects --with-openssl-prefix? If you do this then I don't have to extract the other changes from the patch and can simply apply the patch. Except of the openssl prefix I see no problems.

Sounds fine to me. I'll do that.


Rob


Michael





------------------------------------------------------- This SF.net email is sponsored by: Perforce Software. Perforce is the Fast Software Configuration Management System offering advanced branching capabilities and atomic changes on 50+ platforms. Free Eval! http://www.perforce.com/perforce/loadprog.html _______________________________________________ OpenCA-Devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/openca-devel

Reply via email to