Hi,

we just noticed that no "download" option is presented when displaying
a revoked certificate. Don't know if this is a bug, though.

The corresponding code (0.9.2 branch):

lib/cmds/viewCert, L205ff:

   ## download certs in different formats
    if ( $allow->{SENDCERT} and
         ($dataType =~ /(VALID|EXPIRED|SUSPENDED)/i)
       ) {
        my $select = "<select name=\"format_sendcert\">\n".
                        "<option value=\"pem\">PEM</option>\n".
                        "<option value=\"der\">CER</option>\n".


Question:
- why is REVOKED not included in the condition (VALID|EXPIRED|SUSPENDED)?
- why is there a condition testing the dataType in the first place?

The code below presents the download option for the private key
regardless of the dataType, and I don't see any reason to limit
this for the certificate.

My suggestion is to rephrase it to

       if ( $allow->{SENDCERT} ) {
          my $select = "<select name=\"format_sendcert\">\n".
                        "<option value=\"pem\">PEM</option>\n".
                        "<option value=\"der\">CER</option>\n".


Commenty, anybody?

Martin




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
OpenCA-Devel mailing list
OpenCA-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openca-devel

Reply via email to