Hi Jose,

Jose Manuel Estevez wrote:

lib/cmds/basic_csr:

sub cmdBasic_csr {
...
# begin patch
# my $twig = loadConfigXML (getRequired ("DN_TYPE_".$type."_ELEMENT_".$i."_XML_FILE"));
my $twig = loadConfigXML ("DN_TYPE_".$type."_ELEMENT_".$i."_XML_FILE");
# end patch

...
# begin patch
#my $twig = loadConfigXML (getRequired ("DN_TYPE_".$type."_SUBJECTALTNAME_".$i."_XML_FILE"));
my $twig = loadConfigXML ("DN_TYPE_".$type."_SUBJECTALTNAME_".$i."_XML_FILE");
# end patch
...
}

There were errors only in BASIC ELEMENTS.

I saw that the function getRequired was invoked in the sub loadConfigXML,
so getRequired was invoked twice.

The patch is fully correct. We use the wrong interface. loadConfigXML can be used in two way:

1. only with the name of the configuration parameter
2. FILENAME => $filename (then the function does not call getRequired)

I commited your patch to openca_0_9_2 and CVS HEAD branch. The patch is part of the next 0.9.2.x release. Actually we wait with the next release because we want to include a fix for the Luna HSMs.

fixed revision: 1.43.2.3

Thanks for the patch

Michael
--
_______________________________________________________________

Michael Bell                    Humboldt-Universitaet zu Berlin

Tel.: +49 (0)30-2093 2482       ZE Computer- und Medienservice
Fax:  +49 (0)30-2093 2704       Unter den Linden 6
[EMAIL PROTECTED]   D-10099 Berlin
_______________________________________________________________

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature



Reply via email to