Hi Kevin,
On 03/08/2016 22:22, Kevin Brace wrote:
> commit 46f5f3e181735b23b1eeb4ad84bb0818510cb0f0
> Author: Kevin Brace <kevinbr...@gmx.com>
> Date: Wed Aug 3 13:18:11 2016 -0700
>
> Removing redundant code from via_vt1632.c and via_vt1632.h
>
> via_vt1632_detect function was deleted due to the code inside that
> function being transferred to viaVT1632Init function. Also, several
> discontinued function prototypes were removed.
>
> Signed-off-by: Kevin Brace <kevinbr...@gmx.com>
>
> diff --git a/src/via_vt1632.c b/src/via_vt1632.c
> index 2a3c995..7e669cf 100644
> --- a/src/via_vt1632.c
> +++ b/src/via_vt1632.c
> @@ -200,33 +200,6 @@ via_vt1632_mode_set(xf86OutputPtr output, DisplayModePtr
> mode,
> "Exiting via_vt1632_mode_set.\n"));
> }
>
> -xf86OutputStatus
> -via_vt1632_detect(xf86OutputPtr output)
> -{
> - ViaVT1632Ptr Private = output->driver_private;
> - xf86OutputStatus status;
> - ScrnInfoPtr pScrn = output->scrn;
> - CARD8 tmp;
> -
> - DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> - "Entered via_vt1632_detect.\n"));
> -
> - xf86I2CReadByte(Private->VT1632I2CDev, 0x09, &tmp);
> - if (tmp & 0x04) {
> - xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> - "VT1632A: DVI device is detected.\n");
> - status = XF86OutputStatusConnected;
> - } else {
> - xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> - "VT1632A: DVI device was not detected.\n");
> - status = XF86OutputStatusDisconnected;
> - }
> -
> - DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> - "Exiting via_vt1632_detect.\n"));
> - return status;
> -}
> -
> Bool
> viaVT1632Init(ScrnInfoPtr pScrn, I2CBusPtr pI2CBus)
> {
> diff --git a/src/via_vt1632.h b/src/via_vt1632.h
> index b08345a..06df175 100644
> --- a/src/via_vt1632.h
> +++ b/src/via_vt1632.h
> @@ -47,9 +47,6 @@ void via_vt1632_save(xf86OutputPtr output);
> void via_vt1632_restore(xf86OutputPtr output);
> int via_vt1632_mode_valid(xf86OutputPtr output, DisplayModePtr pMode);
> void via_vt1632_mode_set(xf86OutputPtr output, DisplayModePtr mode,
> DisplayModePtr adjusted_mode);
> -xf86OutputStatus via_vt1632_detect(xf86OutputPtr output);
> -BOOL via_vt1632_probe(ScrnInfoPtr pScrn, I2CDevPtr pDev);
> -ViaVT1632Ptr via_vt1632_init(ScrnInfoPtr pScrn, I2CDevPtr pDev);
> Bool viaVT1632Init(ScrnInfoPtr pScrn, I2CBusPtr pI2CBus);
>
> #endif /* _VIA_VT1632_H_ */
There's something wrong here :
via_tmds.c: In function 'via_dvi_detect':
via_tmds.c:321:14: warning: implicit declaration of function
'via_vt1632_detect' [-Wimplicit-function-declaration]
status = via_vt1632_detect(output);
^
Sorry, too late for me to fix now, but it should be earlier where you live.
Regards,
Xavier
_______________________________________________
Openchrome-devel mailing list
Openchrome-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/openchrome-devel
