On Wed, Mar 20, 2019 at 01:24:19AM +0100, Kevin Brace wrote: > Hi Luc, > > Well, no wonder that portion of the code was relatively clean since the code > James did were generally fairly messy. > Give me a day or two to examine your portion of the code, but at a first > glance, you appear to be correct that he took your code without giving you > credit. > Generally speaking, I do not rely on your past work, so I only learn about > this when you point it out. > This is the second time this has happened (first time was the VT1632(A) DVI > code, and James committed the buggy code into the repository), and if you > wanted to, let me know if there are other portions that other people copied > from your past work without attribution. > I will use "Suggested-by" to refer to you in the commit message, will this be > okay?
_init.c definitely gets my copyright. Code structure of matching functions is 100% the same, just kernel-ized, and my useful comments removed to hide the fact that it was copy pasted. I do not write many comments, structure speaks for itself, but when i do, it is for future reference and it really matters. Luc Verhaegen. _______________________________________________ openchrome-devel mailing list openchrome-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/openchrome-devel
