I have added comment at https://github.com/opencog/atomspace/issues/1645 as suggested by Linas
Organizational points are clear. 2018-04-26 7:55 GMT+03:00 Nil Geisweiller <[email protected]>: > On 04/25/2018 09:21 PM, Linas Vepstas wrote: > >> Writing private emails to me and Nil is just counter-productive. The >> conversation needs to be carried out either on the mailing list, or in >> github, or both. >> > > I totally agree. I did recommend to make discussions public, though > perhaps I did not insist enough (using formulas like "do not hesitate" > instead of "you really should"). > > I am also concerned about the priority of the work. >> https://github.com/opencog/atomspace/labels/pattern-matcher < >> https://github.com/opencog/atomspace/labels/pattern-matcher> lists >> twenty issues that exist in the current pattern matcher. Its not at all >> obvious that parallelizing the pattern matcher is all that important or >> urgent. I am guessing that Ben put you up to this. Some advance >> > > I was asked some motivational task to get Vitaly started and this popped > up in my head. Vitaly has a strong background on System/Network programming > so I thought it was a good match. > > In my opinion it's OK if it's not the highest priority (though I think > it's really cool to have) since it is getting Vitaly familiar with some > very important part of OpenCog. > > planning and organization would have been maybe a bit better. >> > > Yep, I should have been more aggressive on the public thing. I tend not to > like to push people too much, it makes me feel I'm coercing them, but I > think I was out of balance on that one. > > to parallelize the stack; you'll never get it to work right. The >> parallelization MUST happen in the initiate-search loops, and not somewhere >> else. >> > > Just to be clear, that is precisely what Vitaly is doing, parallelizing > the initiate-search loops. > > > Also, totally agree on splitting large PRs into small chunks of cohesive > PRs. > > Vitaly, that would mean for instance that this commit > > https://github.com/vsbogd/atomspace/commit/6c2ab67d026116ceb > f6d2b388f022ef898e854f6 > > of your branch > > https://github.com/vsbogd/atomspace/commits/parallel-pattern-matcher > > should go into another branch, and could probably be pushed ASAP. > > Nil > -- You received this message because you are subscribed to the Google Groups "opencog" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/opencog. To view this discussion on the web visit https://groups.google.com/d/msgid/opencog/CAN28E82cqYA7wGPE_vwXz_2CWDXkJGCqLTnt024%3DJStfqpbMag%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
