Sounds good Arun. So do you want to make the changes to the spec on GitHub or want me to do it?
Thanks, Bhushan From: arunsubash_manic...@dell.com [mailto:arunsubash_manic...@dell.com] Sent: Saturday, April 18, 2015 4:59 AM To: Bhushan Kanekar; opencompute-networking@lists.opencompute.org Subject: RE: Observation on 0.92/saiport.h Hi Bhushan, /* Trap packets with unknown source MAC to CPU. Do not learn. Do not forward */ SAI_PORT_LEARN_MODE_CPU, The intention is to trap to packet to CPU and not forward. This is to be used for authenticating MAC's and not allowing them till its authenticated. Yes there may be cases where user may want to trap to CPU and forward so can we define 2 attributes instead of one /* Trap packets with unknown source MAC to CPU. Do not learn. Do not forward */ SAI_PORT_LEARN_MODE_CPU_DROP, /* Trap packets with unknown source MAC to CPU. Do not learn. Forward based on destination MAC */ SAI_PORT_LEARN_MODE_CPU_FORWARD, -Arun From: opencompute-networking-boun...@lists.opencompute.org<mailto:opencompute-networking-boun...@lists.opencompute.org> [mailto:opencompute-networking-boun...@lists.opencompute.org] On Behalf Of Bhushan Kanekar Sent: Friday, April 17, 2015 10:43 PM To: opencompute-networking@lists.opencompute.org<mailto:opencompute-networking@lists.opencompute.org> Subject: [Opencompute-networking] Observation on 0.92/saiport.h Hi, We noticed the following in 0.92/saiport.h In v0.9.2/saiport.h there is this (apologies for the weird tabulation - I pasted it in): - typedef enum _sai_port_fdb_learning_mode_t { /* Drop packets with unknown source MAC. Do not learn. Do no forward */ SAI_PORT_LEARN_MODE_DROP, /* Do not learn unknown source MAC. Forwarding will occur based on destination MAC */ SAI_PORT_LEARN_MODE_DISABLE, /* Hardware learning. Learn source MAC. Forward based on destination MAC */ SAI_PORT_LEARN_MODE_HW, /* Trap packets with unknown source MAC to CPU. Do not learn. Do not forward */ SAI_PORT_LEARN_MODE_CPU, ) sai_port_fdb_learning_mode_t; There are Silicon which for unknown Source MAC forward the packet in HW and trap a copy of the packet to CPU for SW learning. So is the intention for SAI_PORT_LEARN_MODE_CPU the CPU to do the forwarding in SW (after SW learning the source MAC) or is the comment incorrect. If it is the former than perhaps we should add one more mode to cover the "forward in HW and trap a copy to CPU for SW learning" scenario. If it is the latter than we should correct the comment. Thanks, Bhushan
_______________________________________________ opencompute-networking mailing list Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking opencompute-networking@lists.opencompute.org http://lists.opencompute.org/mailman/listinfo/opencompute-networking
