Hi,
In internal spec review we did for Qos maps spec, we came up with the following
points :
1) For Ingress traffic, we have SAI_QOS_MAP_DOT1P_TO_TC and
SAI_QOS_MAP_DOT1P_TO_COLOR
Why is SAI_QOS_MAP_DOT1P_TO_TC_AND_COLOR needed, as seems redundant and coarse
compared to using the first 2 ?
Same for SAI_QOS_MAP_DSCP_TO_TC, SAI_QOS_MAP_DSCP_TO_COLOR,
SAI_QOS_MAP_DSCP_TO_TC_AND_COLOR
2) For egress traffic, we have
SAI_QOS_MAP_TC_AND_COLOR_TO_DSCP
Why is SAI_QOS_MAP_TC_TO_DSCP needed ? Seems redundant, as coarse compared to
the first attribute, and everything done by the 2nd can be done with the first
attribute
Same for SAI_QOS_MAP_TC_AND_COLOR_TO_DOT1P, SAI_QOS_MAP_TC_TO_DOT1P
3) Re
SAI_QOS_MAP_PRIORITY_GROUP_TO_PFC_PRIORITY
SAI_QOS_MAP_PFC_PRIORITY_TO_QUEUE
We think the mapping should be opposite way around, meaning it
should be:
SAI_QOS_MAP_PFC_PRIORITY_TO_PRIORITY_GROUP
SAI_QOS_MAP_QUEUE_TO_PFC_PRIORITY
As several PFC priorities can be mapped to same group
4) We think a new SAI_PORT_ATTR_UPDATE_DOT1P attribute is needed in order
to enable DOT1P updating on the ingress port like the existing one for the DSCP
- SAI_PORT_ATTR_UPDATE_DSCP.
5) Does the DOT1P mappings include only the 3 PCP bits, or also the
DEI/CFI bit ?
6) Re usage of SAI_PORT_ATTR_QOS_*_MAP and SAI_SWITCH_ATTR_QOS_*_MAP
What is the expected behavior ?
If you set several ports and then set the switch attribute, will the switch
attribute affect only the ports that are at default state and weren’t
explicitly set ?
Would like to avoid this bookkeeping, similar to our decision on default pvid a
month ago
Suggest that the application either uses the port attributes, or the switch
attributes, but not both. Or at least need to define clear semantics.
Appreciate your feedback
Thanks,
Itai
_______________________________________________
opencompute-networking mailing list
Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking
opencompute-networking@lists.opencompute.org
http://lists.opencompute.org/mailman/listinfo/opencompute-networking
