Hi David,

Thank you for this! The patch applied without issues to the current 4.9.30 kernel which is the one we are staging for people who need a 4.x kernel (LTS for Debian 9).

Can you submit it as a pull to ONL or are you ok if I do it? I am refactoring the kernel config to get 4.9 working on systems such as the AS5712 which required this patch.

David Ahern <mailto:dsah...@gmail.com>
July 12, 2017 at 6:58 AM

I ported that patch to 4.11 and it works fine:
https://github.com/dsahern/linux/commit/908a37bb6749d85a7818fb8a0f684d46c858f52e

I don't recall what issues I hit during the port; just grunt work that I
plowed through and moved on.
_______________________________________________
opencompute-networking mailing list
Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking

opencompute-networking@lists.opencompute.org
http://lists.opencompute.org/mailman/listinfo/opencompute-networking
Sushil Dubey <mailto:sushilkdu...@gmail.com>
July 12, 2017 at 6:27 AM

Thanks David for this patch.

I see this patch is for 3.16 and after adopting this to 3.14, i am getting following crash while loading newly built driver.

Is there any other patch which i need to get into my build?

[ 117.284724] Debug /b/sushilkd/Falcon/IGB-DELL/obj-x86-nfx-3/BUILD/igb-nfx-3-5.3.5.4-1/src/e1000_phy.c: 1181 igb_setup_copper_link: [ 117.284742] BUG: unable to handle kernel NULL pointer dereference at (null)
[  117.284743] IP: [<          (null)>]           (null)
[  117.284746] PGD 36de7067 PUD a1843067 PMD 0
[  117.284748] Oops: 0010 [#1] PREEMPT SMP
[ 117.284766] Modules linked in: igb(O+) xt_NFQUEUE xt_multiport pci_stub max6620 lm75 iptable_mangle ipt_REJECT xt_tcpudp bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter ip_tables x_tables openvswitch libcrc32c softdog nfsd i2c_mux_pca954x i2c_mux_gpio_s6000(O) i2c_mux_gpio intel_powerclamp coretemp kvm_intel kvm crct10dif_pclmul crct10dif_common aesni_intel aes_x86_64 glue_helper lrw gf128mul ablk_helper cryptd iTCO_wdt iTCO_vendor_support i2c_i801 i2c_ismt [last unloaded: igb] [ 117.284770] CPU: 0 PID: 3692 Comm: modprobe Tainted: G O 3.14.61-rt58-WR7.0.0.13_ovp #1
[  117.284770] Hardware name: DELL Z9100/Z9100-CPU, BIOS 5.6.5 02/22/2017
[ 117.284772] task: ffff8802288d1920 ti: ffff88009e144000 task.ti: ffff88009e144000 [ 117.284774] RIP: 0010:[<0000000000000000>] [< (null)>] (null)
[  117.284775] RSP: 0018:ffff88009e147a30  EFLAGS: 00010246
[ 117.284776] RAX: 0000000000000078 RBX: ffff880229aa6f18 RCX: 0000000000000000 [ 117.284777] RDX: 0000000000000007 RSI: 0000000000000246 RDI: ffff880229aa6f18 [ 117.284778] RBP: ffff88009e147a60 R08: 0000000000000400 R09: 00000000000003de [ 117.284779] R10: 000000494be24d88 R11: 00000000000003dd R12: 0000000000000000 [ 117.284780] R13: ffff880229aa6f18 R14: ffff88022cfc8000 R15: ffff880229aa6000 [ 117.284782] FS: 00007fb45b319700(0000) GS:ffff88023fc00000(0000) knlGS:0000000000000000
[  117.284783] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 117.284784] CR2: 0000000000000000 CR3: 00000000a183f000 CR4: 00000000001007f0
[  117.284784] Stack:
[ 117.284787] ffffffffa04f370a 000000000000065c ffff880229aa6f18 0000000000000000 [ 117.284788] ffff880229aa6f18 ffff88022cfc8000 ffff88009e147a80 ffffffffa04ee655 [ 117.284790] ffff880229aa6f18 0000000000000020 ffff88009e147aa0 ffffffffa04f1217
[  117.284791] Call Trace:
[ 117.284804] [<ffffffffa04f370a>] ? igb_setup_copper_link+0x4a/0x330 [igb] [ 117.284811] [<ffffffffa04ee655>] igb_setup_copper_link_82575+0x145/0x250 [igb]
[  117.284818]  [<ffffffffa04f1217>] igb_setup_link+0x37/0x190 [igb]
[  117.284824]  [<ffffffffa04ee1d0>] igb_init_hw_82575+0xe0/0x2e0 [igb]
[  117.284830]  [<ffffffffa04e57a1>] igb_reset+0x1f1/0x5f0 [igb]
[  117.284836]  [<ffffffffa04eab80>] igb_sriov_reinit+0x90/0xd0 [igb]
[ 117.284842] [<ffffffffa04eace7>] igb_pci_enable_sriov+0x127/0x1f0 [igb]
[  117.284848]  [<ffffffffa04eb32b>] igb_probe+0x53b/0x1030 [igb]
[  117.284854]  [<ffffffff813ae712>] local_pci_probe+0x42/0xa0
[  117.284856]  [<ffffffff813addfa>] ? pci_match_device+0xda/0xf0
[  117.284858]  [<ffffffff813ae849>] pci_device_probe+0xd9/0x130
[  117.284862]  [<ffffffff8152846e>] driver_probe_device+0x8e/0x270
[  117.284864]  [<ffffffff8152871b>] __driver_attach+0x8b/0x90
[  117.284866]  [<ffffffff81528690>] ? __device_attach+0x40/0x40
[  117.284869]  [<ffffffff815264b3>] bus_for_each_dev+0x73/0xb0
[  117.284871]  [<ffffffff81527fbe>] driver_attach+0x1e/0x20
[  117.284873]  [<ffffffff81527bd8>] bus_add_driver+0x178/0x230
[  117.284875]  [<ffffffff81528d84>] driver_register+0x64/0xf0
[  117.284878]  [<ffffffff813adfae>] __pci_register_driver+0x7e/0x90
[  117.284880]  [<ffffffffa0506000>] ? 0xffffffffa0505fff
[  117.284886]  [<ffffffffa050604f>] igb_init_module+0x4f/0x51 [igb]
[  117.284890]  [<ffffffff81000422>] do_one_initcall+0xf2/0x150
[  117.284893]  [<ffffffff810a0199>] ? rt_up_read+0x19/0x20
[ 117.284896] [<ffffffff8107c982>] ? __blocking_notifier_call_chain+0x52/0x60
[  117.284900]  [<ffffffff810d15e4>] load_module+0x1a64/0x22c0
[  117.284902]  [<ffffffff810ce370>] ? store_uevent+0x40/0x40
[ 117.284905] [<ffffffff810cf499>] ? copy_module_from_fd.isra.50+0x119/0x170
[  117.284908]  [<ffffffff810d1f8e>] SyS_finit_module+0x7e/0x80
[  117.284912]  [<ffffffff81945366>] system_call_fastpath+0x1a/0x1f
[  117.284915] Code:  Bad RIP value.
[  117.284916] RIP  [<          (null)>]           (null)
[  117.284917]  RSP <ffff88009e147a30>
[  117.284917] CR2: 0000000000000000
[  117.620545] ---[ end trace 0000000000000002 ]---



_______________________________________________
opencompute-networking mailing list
Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking

opencompute-networking@lists.opencompute.org
http://lists.opencompute.org/mailman/listinfo/opencompute-networking
David Ahern <mailto:dsah...@gmail.com>
July 11, 2017 at 9:55 AM

https://github.com/opencomputeproject/OpenNetworkLinux/blob/master/packages/base/any/kernels/3.16-lts/patches/driver-support-intel-igb-bcm5461X-phy.patch
_______________________________________________
opencompute-networking mailing list
Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking

opencompute-networking@lists.opencompute.org
http://lists.opencompute.org/mailman/listinfo/opencompute-networking
Sushil Dubey <mailto:sushilkdu...@gmail.com>
July 11, 2017 at 9:51 AM
Hello Everyone,

I am working on Dell Z9100 system based on Rangeley with I354 GBE with BCM 54616S phy on management port.

(*https://github.com/opencomputeproject/onie/blob/master/patches/kernel/3.2.69/driver-support-intel-avoton-ethernet-with-broadcom-phy.patch*)

I am using Linux 3.14 version, and hitting following issue.


root@localhost:/usr# dmesg | grep -i igb

[0.857879] igb: Intel(R) Gigabit Ethernet Network Driver - version 5.0.5-k

[0.857881] igb: Copyright (c) 2007-2013 Intel Corporation.

[0.858343] igb: probe of 0000:00:14.0 failed with error -2

[0.858670] igb: probe of 0000:00:14.1 failed with error -2

[0.859015] igb: probe of 0000:00:14.2 failed with error -2



When i integrated igb-5.3.5.4, i hit following issue.


[  157.168461] Intel(R) Gigabit Ethernet Network Driver - version 5.3.5.4

[  157.168466] Copyright (c) 2007-2015 Intel Corporation.

[  157.169140] igb 0000:00:14.0: Hardware Initialization Failure

[  157.174226] igb: probe of 0000:00:14.0 failed with error -5

[  157.174596] igb 0000:00:14.1: Hardware Initialization Failure

[  157.179672] igb: probe of 0000:00:14.1 failed with error -5

[  157.180030] igb 0000:00:14.2: Hardware Initialization Failure

[  157.185222] igb: probe of 0000:00:14.2 failed with error -5


Can anyone please point me if there is any working IGB version for this with BCM Phy supports?



Thanks,

Sushil



_______________________________________________
opencompute-networking mailing list
Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking

opencompute-networking@lists.opencompute.org
http://lists.opencompute.org/mailman/listinfo/opencompute-networking

_______________________________________________
opencompute-networking mailing list
Unsubscribe: http://lists.opencompute.org/mailman/options/opencompute-networking

opencompute-networking@lists.opencompute.org
http://lists.opencompute.org/mailman/listinfo/opencompute-networking

Reply via email to