Do note that all three of these scripts are explicitly intended+tested
*only* to run under Bash…

     $ head -n1 android/fetch.sh trojans/csd-*.sh
     ==> android/fetch.sh <==
     #!/bin/bash

     ==> trojans/csd-post.sh <==
     #!/bin/bash

     ==> trojans/csd-wrapper.sh <==
     #!/bin/bash

Is there some specific environment where your modifications make them
work with a "plain" POSIX sh, where they didn't previously work
correctly?

Hi,

Indeed why change something that works? Let's have a look at the documentation:

  Compound Commands
    ...
    [[ expression ]]
        ...
        When the == and != operators are used, the string to the
        right of the operator is considered a pattern and matched
        according to the rules described below under Pattern
        Matching, as if the extglob shell option were enabled.
        The = operator is equivalent to ==.
        ...

        An additional binary operator, =~, is available, with the
        same precedence as == and !=.  When it is used, the string
        to the right of the operator is considered a POSIX
        extended regular expression and matched accordingly (using
        the POSIX regcomp and regexec interfaces usually described
        in regex(3)).
        ...

Perhaps the double [[ == ]] can be changed to [ = ] in most cases, as it implies regular expressions might be involved - but they are not.

--
Dimitri Papadopoulos

_______________________________________________
openconnect-devel mailing list
openconnect-devel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/openconnect-devel

Reply via email to