-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Klaus,
On 06/17/2010 06:40 PM, Klaus Heinrich Kiwi wrote: > On Wed, 16 Jun 2010 11:34:51 -0300 > Ramon de Carvalho Valle <[email protected]> wrote: > >> Check the return values of RSA_public_encrypt and RSA_private_decrypt >> functions appropriately. >> >> Signed-off-by: Ramon de Carvalho Valle <[email protected]> >> --- >> usr/lib/pkcs11/soft_stdll/soft_specific.c | 35 >> +++++++++++++++------------- 1 files changed, 19 insertions(+), 16 >> deletions(-) >> > > > Ramon, > > after applying your patchset, looks like something is missing: > > make[4]: Entering directory > `/home/klausk/sandbox/ock/sourceforge-git/opencryptoki/usr/lib/pkcs11/soft_stdll' > /bin/sh ../../../../libtool --tag=CC --mode=compile gcc > -DPACKAGE_NAME=\"openCryptoki\" -DPACKAGE_TARNAME=\"opencryptoki\" > -DPACKAGE_VERSION=\"2.3.1\" -DPACKAGE_STRING=\"openCryptoki\ 2.3.1\" > -DPACKAGE_BUGREPORT=\"[email protected]\" > -DPACKAGE=\"opencryptoki\" -DVERSION=\"2.3.1\" -DSTDC_HEADERS=1 > -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 > -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 > -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 > -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_FILE_H=1 > -DHAVE_SYSLOG_H=1 -DHAVE_UNISTD_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 > -DHAVE_STRFTIME=1 -DHAVE_VPRINTF=1 -DHAVE_GETCWD=1 -I. -DSPINXPL -DDEV > -D_THREAD_SAFE -DSHALLOW=0 -DSWTOK=1 -DLITE=0 -DNOCDMF -DNOMD2 -DNODSA > -DNORIPE -DDEBUGON -fPIC -I/usr/include -I. -I../../../include/pkcs11/stdll > -I../../../include/pkcs11 -I../common -DSTDLL_NAME=\"swtok\" -g -O0 -DPKC S64 -D_XOPEN_SOURCE=500 -DCONFIG_PATH=\"/usr/local/var/lib/opencryptoki\" -DSBIN_PATH=\"/usr/local/sbin\" -DLIB_PATH=\"/usr/local/lib\" -MT opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.lo -MD -MP -MF .deps/opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.Tpo -c -o opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.lo `test -f '../common/mech_rsa.c' || echo './'`../common/mech_rsa.c > libtool: compile: gcc -DPACKAGE_NAME=\"openCryptoki\" > -DPACKAGE_TARNAME=\"opencryptoki\" -DPACKAGE_VERSION=\"2.3.1\" > "-DPACKAGE_STRING=\"openCryptoki 2.3.1\"" > -DPACKAGE_BUGREPORT=\"[email protected]\" > -DPACKAGE=\"opencryptoki\" -DVERSION=\"2.3.1\" -DSTDC_HEADERS=1 > -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 > -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 > -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 > -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_FILE_H=1 > -DHAVE_SYSLOG_H=1 -DHAVE_UNISTD_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 > -DHAVE_STRFTIME=1 -DHAVE_VPRINTF=1 -DHAVE_GETCWD=1 -I. -DSPINXPL -DDEV > -D_THREAD_SAFE -DSHALLOW=0 -DSWTOK=1 -DLITE=0 -DNOCDMF -DNOMD2 -DNODSA > -DNORIPE -DDEBUGON -fPIC -I/usr/include -I. -I../../../include/pkcs11/stdll > -I../../../include/pkcs11 -I../common -DSTDLL_NAME=\"swtok\" -g -O0 -DPKCS64 > -D_XOPEN_SOURCE=500 -DCONFIG_PATH= \"/usr/local/var/lib/opencryptoki\" -DSBIN_PATH=\"/usr/local/sbin\" -DLIB_PATH=\"/usr/local/lib\" -MT opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.lo -MD -MP -MF .deps/opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.Tpo -c ../common/mech_rsa.c -fPIC -DPIC -o .libs/opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.o > ../common/mech_rsa.c: In function ‘rsa_pkcs_verify’: > ../common/mech_rsa.c:839: error: ‘out_data’ undeclared (first use in this > function) > ../common/mech_rsa.c:839: error: (Each undeclared identifier is reported only > once > ../common/mech_rsa.c:839: error: for each function it appears in.) > ../common/mech_rsa.c:839: error: ‘out_data_len’ undeclared (first use in this > function) > ../common/mech_rsa.c: In function ‘rsa_pkcs_verify_recover’: > ../common/mech_rsa.c:872: error: ‘out_data’ redeclared as different kind of > symbol > ../common/mech_rsa.c:867: note: previous definition of ‘out_data’ was here > ../common/mech_rsa.c:873: error: ‘out_data_len’ redeclared as different kind > of symbol > ../common/mech_rsa.c:868: note: previous definition of ‘out_data_len’ was here > ../common/mech_rsa.c:902: error: invalid type argument of ‘unary *’ (have > ‘CK_ULONG’) > ../common/mech_rsa.c:910: warning: passing argument 4 of ‘rsa_parse_block’ > makes pointer from integer without a cast > ../common/mech_rsa.c:450: note: expected ‘CK_ULONG *’ but argument is of type > ‘CK_ULONG’ > make[4]: *** [opencryptoki_stdll_libpkcs11_sw_la-mech_rsa.lo] Error 1 > > I haven't pushed the changes upstream yet. Can you take a look and perhaps > re-send? It is strange, both the patch series I sent previously and the series I will re-send, builds flawlessly in my branch. Could you try merging from my branch? It is "rcvalle" in /root/opencryptoki repository at popcorn. > > Thanks! Thanks! > > - -- Ramon de Carvalho Valle Software Engineer IBM Linux Technology Center E-Mail: [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkwa5eYACgkQGIS0iEuhp4MXcACgz9CrARc0fF0IxValkM6b2aTi /pAAoKpYP+MtprFYDohmCgZa8cMRL++riEYEARECAAYFAkwa5eYACgkQkcIYeh81 wLkXcACcD0X1JeGXNp0FofUTb8Z4884zQhMAn2bYitwFXbietmO/1xqMjnUXcLT0 =WaZn -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
