On Tue, 3 Aug 2010 10:33:07 -0500 Kent Yoder <[email protected]> wrote:
Thanks for the patch, Kent. A minor comment below: > diff --git a/usr/lib/pkcs11/cca_stdll/Makefile.am > b/usr/lib/pkcs11/cca_stdll/Makefile.am index f0b5a6a..4fc189e 100644 > --- a/usr/lib/pkcs11/cca_stdll/Makefile.am > +++ b/usr/lib/pkcs11/cca_stdll/Makefile.am > @@ -54,4 +54,8 @@ noinst_HEADERS = h_extern.h tok_spec_struct.h > defs.h csulincl.h \ install-data-hook: > cd $(DESTDIR)/$(libdir)/opencryptoki/stdll && \ > ln -sf libpkcs11_cca.so PKCS11_CCA.so > - $(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/opencryptoki/ccatok ^^^^^ > + > +uninstall-hook: > + if test -d $(DESTDIR)/$(libdir)/opencryptoki/stdll; then \ > + cd $(DESTDIR)/$(libdir)/opencryptoki/stdll && \ > + rm -f PKCS11_CCA.so; fi > diff --git a/usr/lib/pkcs11/cr_stdll/Makefile.am > b/usr/lib/pkcs11/cr_stdll/Makefile.am index 2ee7a20..9658551 100644 > --- a/usr/lib/pkcs11/cr_stdll/Makefile.am > +++ b/usr/lib/pkcs11/cr_stdll/Makefile.am > @@ -31,3 +31,8 @@ INCLUDES = $(CR_INC_DIRS) > -I/usr/include \ install-data-hook: > cd $(DESTDIR)$(libdir)/opencryptoki/stdll && \ > ln -sf libpkcs11_cr.so PKCS11_CR.so > + > +uninstall-hook: > + if test -d $(DESTDIR)$(libdir)/opencryptoki/stdll; then \ > + cd $(DESTDIR)$(libdir)/opencryptoki/stdll && \ > + rm -f PKCS11_CR.so; fi > diff --git a/usr/lib/pkcs11/ica_s390_stdll/Makefile.am > b/usr/lib/pkcs11/ica_s390_stdll/Makefile.am index b881e17..86e061e > 100644 --- a/usr/lib/pkcs11/ica_s390_stdll/Makefile.am > +++ b/usr/lib/pkcs11/ica_s390_stdll/Makefile.am > @@ -29,4 +29,8 @@ INCLUDES = $(ICA_INC_DIRS) -I. > -I../../../include/pkcs11/stdll \ install-data-hook: > cd $(DESTDIR)$(libdir)/opencryptoki/stdll && \ > ln -sf libpkcs11_ica.so PKCS11_ICA.so > - $(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/opencryptoki/lite ^^^^^^ > + > +uninstall-hook: > + if test -d $(DESTDIR)$(libdir)/opencryptoki/stdll; then \ > + cd $(DESTDIR)$(libdir)/opencryptoki/stdll && \ > + rm -f PKCS11_ICA.so; fi Are those exclusions intentional? Thanks. -Klaus -- Klaus Heinrich Kiwi | [email protected] | http://blog.klauskiwi.com Open Source Security blog : http://www.ratliff.net/blog IBM Linux Technology Center : http://www.ibm.com/linux/ltc ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
