Hi Klaus, On Fri, Aug 13, 2010 at 8:50 AM, Klaus Heinrich Kiwi <[email protected]> wrote: > Opencryptoki has a number of places which use misc pkcs#11 utility > functions. > > This patch creates p11util.c which to start consolidating those > functions in one place. > > Signed-off-by: Klaus Heinrich Kiwi <[email protected]> > --- > testcases/common/Makefile.am | 4 +- > testcases/common/common.c | 91 ------ > testcases/driver/Makefile.am | 4 +- > testcases/include/regress.h | 5 +- > testcases/init_tok/Makefile.am | 4 +- > testcases/login/Makefile.am | 4 +- > testcases/login/common.c | 97 +------ > testcases/mkobj/Makefile.am | 4 +- > testcases/oc-digest/Makefile.am | 4 +- > testcases/oc-digest/oc-digest.c | 94 +------ > testcases/rsa_keygen/Makefile.am | 4 +- > testcases/rsa_test/Makefile.am | 4 +- > testcases/speed/Makefile.am | 4 +- > testcases/test_crypto/Makefile.am | 4 +- > testcases/threadmkobj/Makefile.am | 4 +- > testcases/tok_obj/Makefile.am | 4 +- > testcases/tok_obj/tok_obj2.c | 98 +------ > testcases/v2.11/Makefile.am | 4 +- > usr/lib/pkcs11/cca_stdll/h_extern.h | 2 - > usr/lib/pkcs11/cca_stdll/utility.c | 74 ----- > usr/lib/pkcs11/common/h_extern.h | 3 - > usr/lib/pkcs11/common/p11util.c | 463 > +++++++++++++++++++++++++++++ > usr/lib/pkcs11/common/p11util.h | 310 +++++++++++++++++++ > usr/lib/pkcs11/common/template.c | 1 + > usr/lib/pkcs11/common/utility.c | 74 -----
Hmm, we are pulling code out of common/utility.c to put in common/p11util.c? > usr/lib/pkcs11/ica_s390_stdll/Makefile.am | 6 +- > usr/lib/pkcs11/soft_stdll/Makefile.am | 1 + > usr/lib/pkcs11/tpm_stdll/Makefile.am | 1 + > usr/lib/pkcs11/tpm_stdll/h_extern.h | 3 - > usr/lib/pkcs11/tpm_stdll/utility.c | 75 ----- > 30 files changed, 814 insertions(+), 636 deletions(-) > create mode 100755 usr/lib/pkcs11/common/p11util.c > create mode 100755 usr/lib/pkcs11/common/p11util.h > > diff --git a/usr/lib/pkcs11/common/p11util.c b/usr/lib/pkcs11/common/p11util.c > new file mode 100755 > index 0000000..7b60a36 > --- /dev/null > +++ b/usr/lib/pkcs11/common/p11util.c > @@ -0,0 +1,463 @@ > +/* > + Common Public License Version 0.5 Do we need the full license in new files? If so I bet we are missing it some other places, but last I knew having one LICENSE file in the project root was ok... The rest of the patch looks good, can you resend this as it applies over the master branch? Thanks, Kent ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
