On Fri, 14 Jan 2011 01:17:56 +0100
Diego Elio Pettenò <[email protected]> wrote:

> The sources require an inclusion of <string.h> for memmove() and of
> <stdio.h> for sprintf().
> 
> Implicit declarations both cannot be properly validated by the compiler and
> will stop fortified sources in modern glibc from working.

Good catch. Thanks for the patch.

 Applied to the master branch.

> ---
>  usr/lib/pkcs11/common/p11util.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/usr/lib/pkcs11/common/p11util.c b/usr/lib/pkcs11/common/p11util.c
> index 8231145..8807fd6 100755
> --- a/usr/lib/pkcs11/common/p11util.c
> +++ b/usr/lib/pkcs11/common/p11util.c
> @@ -290,6 +290,8 @@
> 
> 
>  #include <stdlib.h>
> +#include <string.h>
> +#include <stdio.h>
>  #include "pkcs11types.h"
> 
>  #define _sym2str(X)     case X: return #X



-- 
Klaus Heinrich Kiwi | [email protected] | http://blog.klauskiwi.com
Open Source Security blog :     http://www.ratliff.net/blog
IBM Linux Technology Center :   http://www.ibm.com/linux/ltc

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Opencryptoki-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech

Reply via email to