On Sat, 22 Jan 2011 20:41:00 +0100 Andreas Piesk <[email protected]> wrote:
> Bugfixes: > > opencryptoki-2.3.3_slotid.patch > > * lcv is uninitialized, replaced by slot_id > * Signed-off-by: Andreas Piesk <[email protected]> good catch, thanks for the patch. > > opencryptoki-2.3.3_catcheof.patch > > * check if a really empty pin was entered (^D) to prevent a segfault > * Signed-off-by: Andreas Piesk <[email protected]> The segfault is true, but for token label, not PIN (getting PINs from the terminal is handled by the getpin() function), so is just a matter of describing it right. And the CKR_ error you're using really doesn't mean much in this context. > > opencryptoki-2.3.3_msgid.patch > > * replace VERSION by VVERSION, VERSION is the software version not the cat > msg id > * Signed-off-by: Andreas Piesk <[email protected]> good catch! > opencryptoki-2.3.3_mechlist.patch > > * option -m needs a slot id to list the mechs > * Signed-off-by: Andreas Piesk <[email protected]> Looks OK. > opencryptoki-2.3.3_warnings.patch > > * missing includes added > * depreceted includes tss/tcpa_* removed > * some casts to silence the compiler > * Signed-off-by: Andreas Piesk <[email protected]> Looks OK. > > > currently i'm adding cmdline parsing to pkcsslotd but the '#ifdef DEV' stuff > makes it a little bit > difficult. I don't believe we're even using this symbol anymore. It should be OK to just strip everything under #ifdef DEV. If you're removing it, make sure you stage your patches so that one thing doesn't mix-up with another. > regards, > -ap I haven't applied the above patches mostly because of the opencryptoki-2.3.3_catcheof.patch, which needs some rework. Could you please rework that and send everything again using git-send-email? Thanks! -- Klaus Heinrich Kiwi | [email protected] | http://blog.klauskiwi.com Open Source Security blog : http://www.ratliff.net/blog IBM Linux Technology Center : http://www.ibm.com/linux/ltc ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Opencryptoki-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech
