Oops.  Forgot to commit.

Greg

Dave Johnson <[EMAIL PROTECTED]>@opendx.watson.ibm.com on 12/09/99
02:22:42 PM

Please respond to [email protected]

Sent by:  [EMAIL PROTECTED]


To:   [email protected]
cc:
Subject:  Re: [opendx-dev] Re: help with make



On Fri, Dec 03, 1999 at 03:48:51PM -0500, [EMAIL PROTECTED] wrote:
> Nobody cares about the value returned from the function.  Rip out both
> definitions of func, and don't assign the return from the procedure.
I've
> made the change to CVS.
>
> Greg
>

Yes, just void out the return... that works for me too.

But I don't see any changes since October to the DXApplication.C in CVS...
Here are my diffs:

Index: DXApplication.C
===================================================================
RCS file: /src/master/dx/src/uipp/dxuilib/DXApplication.C,v
retrieving revision 1.14
diff -c -r1.14 DXApplication.C
*** DXApplication.C 1999/10/26 19:19:44  1.14
--- DXApplication.C 1999/12/09 19:19:15
***************
*** 4709,4721 ****
      unsigned int key_buttons;
      Boolean      boolx;
      Window       win;
- #if defined(OS2) || NeedNestedPrototypes
-     int          (*func)(Display *);
- #else
-     int          (*func)();
- #endif

!     func = XSetAfterFunction(display, NULL);
      win  = RootWindow(display,0);
      boolx = XQueryPointer(display,
                           win,
--- 4709,4716 ----
      unsigned int key_buttons;
      Boolean      boolx;
      Window       win;

!     (void) XSetAfterFunction(display, NULL);
      win  = RootWindow(display,0);
      boolx = XQueryPointer(display,
                           win,
***************
*** 4726,4732 ****
                           &win_x,
                           &win_y,
                           &key_buttons);
!     func = XSetAfterFunction(display, DXApplication_DXAfterFunction);
      return 1;
  }

--- 4721,4727 ----
                           &win_x,
                           &win_y,
                           &key_buttons);
!     (void) XSetAfterFunction(display, DXApplication_DXAfterFunction);
      return 1;
  }


>
> Dave Johnson <[EMAIL PROTECTED]>@opendx.watson.ibm.com on 12/03/99
> 03:38:16 PM
>

--- snip -----

> Solutions???
>
> 1) put an explicit cast between the assignment and the function call.
> This forces the return value to be what it should have been if IBM and
> SGI had gotten more recent X include files.
>
> 2) fix the include file on the system.   Naahhh.
>
> 3) change NeedNestedPrototypes to
>      (NeedNestedPrototypes && !defined(_AIX) && !defined(SGI))
> or whatever is appropriate.
>  Yechh.  This will fail when/if the Xlib.h is finally fixed.
>
> I think I am going to do #1 for now.

--- snip -----


     Dave Johnson
     Brown University TCASCV
     [EMAIL PROTECTED]


Reply via email to