STRSTREA_H and STRSTREAM_H are not the same. On older Windows systems with limitations on 8.3 character names, these files were not the same. As long as nobody is compiling for Windows 95 or lower, this fix would be acceptable. But since it is not harming anything, I don't see a reason not to leave it in for the time being.

David

David Thompson wrote:


 Look at those carefully, they are not the same. I'm not aware of
 compilers that don't support it, but we do have enough that one of them
 might not (xlc, Forte, gcc, Visual Studio).

OK. I don't know about these compilers.
However, still there's some obvious overdoing the if-checking,
which is stripped in this patch:


Index: src/uipp/prompter/GARApplication.h
===================================================================
RCS file: /src/master/dx/src/uipp/prompter/GARApplication.h,v
retrieving revision 1.12
diff -u -r1.12 GARApplication.h
--- src/uipp/prompter/GARApplication.h  11 Jul 2003 05:50:56 -0000      1.12
+++ src/uipp/prompter/GARApplication.h  16 Sep 2003 06:00:49 -0000
@@ -16,9 +16,7 @@
 #include <sstream>
 #elif defined(HAVE_STRSTREAM_H)
 #include <strstream.h>
-#endif
-
-#if defined(HAVE_STRSTREA_H)
+#elif defined(HAVE_STRSTREA_H)
 #include <strstrea.h>
 #endif

Index: src/uipp/startup/StartupApplication.h
===================================================================
RCS file: /src/master/dx/src/uipp/startup/StartupApplication.h,v
retrieving revision 1.9
diff -u -r1.9 StartupApplication.h
--- src/uipp/startup/StartupApplication.h  11 Jul 2003 05:50:57 -0000    1.9
+++ src/uipp/startup/StartupApplication.h  16 Sep 2003 06:00:49 -0000
@@ -23,10 +23,6 @@
 #include <strstrea.h>
 #endif

-#if defined(HAVE_STRSTREA_H)
-#include <strstrea.h>
-#endif
-
 #include <Xm/Xm.h>

 #include "../base/MainWindow.h"


--
.............................................................................
David L. Thompson                   Visualization and Imagery Solutions, Inc.
mailto:[EMAIL PROTECTED]    5515 Skyway Drive, Missoula, MT 59804
                                    Phone : (406)756-7472

Reply via email to