Hi Adam, Heath
The attribute in question, original_author is an attribute of Class
RESOURCE_DESCRIPTION from rm.common.resource package. According to the specs
(common_im.pdf), the type is Hash<String,String> NOT a string and the
invariant on it is "Original_author_valid: original_author /= Void and then
not original_author.is_empty".
The Java implementation (see below) of this invariant is, I believe,
faithful interpretation of the specs.
if (originalAuthor == null || originalAuthor.size() == 0 ) {
throw new IllegalArgumentException("null or empty originalAuthor");
}
The thing I am not sure here is the XML schema. If the schema is not
compliant with the RM specs, perhaps the schema should be updated so the
parsing code generated from schema can catch errors like this, thoughts?
Cheers,
Rong
On Thu, Nov 6, 2008 at 2:10 AM, Heath Frankel <
heath.frankel at oceaninformatics.com> wrote:
> Hi Adam,
> Can you provide details of the offending archetype?
>
> Looking at the AOM, the originalAuthor is a required attribute and this is
> reflected in the Resource.xsd. However apart from the list being
> non-empty,
> I see no other invariant to that states that the value of the
> originalAuthor
> item cannot be an empty string.
>
> Therefore I would suggest that the Java IllegalArgumentException "null or
> empty originalAuthor" is too tight. A "not null" invariant seems
> reasonable.
>
> However, not being a member of the java implementation I will leave that to
> them to decide what to do here.
>
> If there is an issue with the Ocean XML output please feel free to contact
> me directly.
>
> Heath
>
> > -----Original Message-----
> > From: openehr-technical-bounces at openehr.org [mailto:openehr-technical-
> > bounces at openehr.org] On Behalf Of Adam Flinton
> > Sent: Thursday, 6 November 2008 1:30 AM
> > To: Java OpenEHR; openEHR technical discussions
> > Subject: Is originalAuthor required?
> >
> > Dear All,
> >
> > Running the Java ADL > XML & I get a fair few errors of the type:
> >
> > Error Class: java.lang.IllegalArgumentException Message: null or empty
> > originalAuthor
> >
> > Is originalAuthor a required structure?
> >
> > If so then the Ocean ADL > XML is not picking that up.
> > If not then could the Java code be amended to not error if it is not
> > present.
> >
> > TIA
> >
> > Adam
> >
> >
> >
> > ***********************************************************************
> > This message may contain confidential and privileged information.
> > If you are not the intended recipient you should not disclose, copy
> > or distribute information in this e-mail or take any action in reliance
> > on its contents. To do so is strictly prohibited and may be unlawful.
> > Please inform the sender that this message has gone astray before
> > deleting it. Thank you.
> >
> > 2008 marks the 60th anniversary of the NHS. It's an opportunity to pay
> > tribute to the NHS staff and volunteers who help shape the service, and
> > celebrate their achievements.
> >
> > If you work for the NHS and would like an NHSmail email account, go
> > to: www.connectingforhealth.nhs.uk/nhsmail
> > ***********************************************************************
> >
> > _______________________________________________
> > openEHR-technical mailing list
> > openEHR-technical at openehr.org
> > http://lists.chime.ucl.ac.uk/mailman/listinfo/openehr-technical
>
> _______________________________________________
> openEHR-technical mailing list
> openEHR-technical at openehr.org
> http://lists.chime.ucl.ac.uk/mailman/listinfo/openehr-technical
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.openehr.org/mailman/private/openehr-technical_lists.openehr.org/attachments/20081107/8a380b76/attachment.html>
