Bert,
Re: the 'units' problem, see my answer previously posted:
>
> Treating "units" etc as keywords is a pretty dirty way to implement
> dADL (now ODIN) parsing! The property names in a C_DV_QUANTITY (or
> C_DV_ORDINAL) structure shouldn't be keywords, they are just property
> names, and should be collected and either compared to the RM or (what
> I do) converted straight to an object by the dADL (ODIN) deserialiser.
>
> As per my recent post, all of this is now gone in ADL 1.5.
>
> IN any case, I would not expect any problem with picking up "units" in
> two different parsing contexts in the parser.
>
> - thomas
you might want to consider posting these issues on the Java list, you'll
probably get more answers there... not everyone bothers to read all
messages on this list if they are busy.
- thomas
On 02/09/2013 13:50, Bert Verhees wrote:
> LinkEHR writes an archetypenode id in a use_node, the Java ADL-parser
> regards this as erroneous, although it is permitted in the AOM, where
> there is an nodeId in the ArchetypeInternalRef constructor.
>
> The repair in adl.jj was, however simply to do. I tested it with all
> available testfiles, and also with adding an nodeId in the
> adl-test-entry.archetype_internal_ref.test-arc hetype, like this:
>
> attribute3 matches {
> use_node SECTION /items[at0001]
> use_node SECTION /items[at0002]
> }
> attribute4 matches {
> use_node SECTION[at0005] /items[at0001]
> use_node SECTION[at0006] /items[at0002]
> }
>
> I copied the needed code-change down below:
>
> ArchetypeInternalRef archetype_internal_ref(String path, CAttribute
> parent) :
> {
> String type;
> Interval<Integer> occurrences = new Interval<Integer>(1, 1);
> String target;
> String nodeID = null;
> }
> {
> <SYM_USE_NODE> type = type_identifier()
> [ nodeID = constraint_ref() ]
> [ occurrences = c_occurrences() ]
> target = absolute_path()
> {
> return new ArchetypeInternalRef(path, type, occurrences, nodeID,
> parent,
> target);
> }
> }
> ---------------------------------------
> Also, I mentioned another problem in the ADL-parser last week, but I
> got no feedback on that, it was maybe because it was a bit confusing.
>
> Again, below the description and how to change the code:
>
> The ADL-Parser is not capable of parsing EN13606 archetypes because of
> the keyword "units" which belongs to the EN13606 datatype PQ.
>
> I solved this problem by commenting out all occurrences of SYM_UNITS
>
> This is in line 2958, becomes:
> CDvQuantityItem c_dv_quantity_item() :
> {
> Interval value = null;
> Interval precision = null;
> String units;
> }
> {
> "[" string_value() "]" <SYM_EQ> "<"
>
> (<SYM_C_QUANTITY_UNITS>) <SYM_EQ> "<"
> units = string_value()
> ">"
>
> [
> <SYM_MAGNITUDE> <SYM_EQ> "<"
> value = real_interval_value()
> ">"
> ]
>
> [
> <SYM_PRECISION> <SYM_EQ> "<"
> precision = integer_interval_value()
> ">"
> ]
> ">"
> {
> return new CDvQuantityItem(value, precision, units);
> }
> }
>
> and line 341 containing: | < SYM_UNITS: "units"> :DOMAIN_TYPE_C_QUANTITY
> is removed
> --------------------------
> I don't know if it is wished that both issues which are repaired this
> way will be posted in the according repository.
> If so, I can post the change.
>
> If not, it works for me.
>
> Thanks
> Bert
>
>
> _______________________________________________
> openEHR-technical mailing list
> openEHR-technical at lists.openehr.org
> http://lists.openehr.org/mailman/listinfo/openehr-technical_lists.openehr.org
>
>
--
Ocean Informatics <http://www.oceaninformatics.com/> *Thomas Beale
Chief Technology Officer*
+44 7792 403 613 Specification Program, /open/EHR
<http://www.openehr.org/>
Honorary Research Fellow, UCL <http://www.chime.ucl.ac.uk/>
Chartered IT Professional Fellow, BCS <http://www.bcs.org.uk/>
Health IT blog <http://wolandscat.net/category/health-informatics/>
View Thomas Beale's profile on LinkedIn
<http://uk.linkedin.com/in/thomasbeale>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.openehr.org/pipermail/openehr-technical_lists.openehr.org/attachments/20130902/3d541210/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ocean_full_small.jpg
Type: image/jpeg
Size: 4085 bytes
Desc: not available
URL:
<http://lists.openehr.org/pipermail/openehr-technical_lists.openehr.org/attachments/20130902/3d541210/attachment-0001.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: btn_liprofile_blue_80x15.png
Type: image/png
Size: 511 bytes
Desc: not available
URL:
<http://lists.openehr.org/pipermail/openehr-technical_lists.openehr.org/attachments/20130902/3d541210/attachment-0001.png>
