On Nov 29, 2006, at 10:00 AM, Mohammad Nour El-Din wrote:

Hi All...

Would someone please review this patch
http://issues.apache.org/jira/browse/OPENEJB-387


Reviewed and applied. I have to say I liked the path quite a bit. Simple, clean and with javadoc worthy of the website. Check it out:

    /*
* The algorithm of OpenEJB deployments class-path inclusion and exclusion is implemented as follows: * 1- If the string value of the resource URL matches the include class-path pattern
     *     Then load this resource
* 2- If the string value of the resource URL matches the exclude class-path pattern
     *     Then ignore this resource
* 3- If the include and exclude class-path patterns are not defined
     *     Then load this resource
     *
     * The previous steps are based on the following points:
     *  1- Include class-path pattern has the highst priority
* This helps in case both patterns are defined using the same values.
     *     This appears in step 1 and 2 of the above algorithm.
* 2- Loading the resource is the default behaviour in case of not defining a value for any class-path pattern
     *     This appears in step 3 of the above algorithm.
     */

That's exactly how I would have coded that algorithm too.

-David

Reply via email to