Hi David... Thanks :), I checked the specs again and I found that what you mentioned about the lookup method and the changes you made are right, it is mentioned under section 4.5.2 Table-2. Thanks again :)
On 1/7/07, David Blevins <[EMAIL PROTECTED]> wrote:
On Jan 6, 2007, at 4:15 PM, Mohammad Nour El-Din wrote: > Hi David... > > First sorry to be late to submit the patch, and I will start on > OPENEJB-127 > tomorrow, second thanks for reviewing the patch and the changes you > made, I > might didn't notice the restrictions you mentioned while I was > reading the > specs :). I have only one question the, OPENEJB-368 JIRA is > assigned now to > Manu while it is closed, I am afraid it was closed while it was > assigned to > him and then I will loose my effort to this patch :D, don't miss- > understand > me but I just wanted to ask maybe something wrong happened. Whoops! My bad! :) It's assigned to you now. Thanks again, Mohammad! Feel free to bug the list on OPENEJB-127, it's not entirely a steamed out idea. -David > > > On 1/5/07, David Blevins <[EMAIL PROTECTED]> wrote: > >> >> On Jan 4, 2007, at 11:31 AM, David Blevins wrote: >> >> > On Jan 4, 2007, at 11:06 AM, Mohammad Nour El-Din wrote: >> > >> >> Hi All... >> >> >> >> Would someone please review the patch of JIRA >> >> http://issues.apache.org/jira/browse/OPENEJB-368 which solves both >> >> OPENEJB-368 and http://issues.apache.org/jira/browse/OPENEJB-159 >> >> >> > Looking into it! >> >> All committed! >> >> Nice patch, Mohammad. I did change a couple things. The lookup >> method was accepting "java:comp/env" type lookups which it shouldn't, >> so I just changed it to tack that on before doing the lookup. I also >> renamed the test case to follow the ContextLookupTests that I created >> for you earlier and also fixed the lookup strings to not contain >> "java:comp/env/". >> >> Thank you very much! >> >> -David >> >> > > > -- > Thanks > - Mohammad Nour
-- Thanks - Mohammad Nour
