On Jan 12, 2007, at 12:06 PM, Kevan Miller wrote:
On Jan 12, 2007, at 2:11 PM, David Blevins wrote:
On Jan 12, 2007, at 9:48 AM, Kevan Miller wrote:
FYI, I ran a scan of the current source files in trunk/openejb3
using the RAT tool. Here are the results:
A number of files are using old-style 2.0 license headers or V1.1
license headers.
Nothing was using old-style ASL 2.0, but I did update the three
using the 1.1 header. Also updated the other three test files
that crept in that didn't have headers.
Oops. Thanks for noting that. I thought ARAT had starting flagging
old 2.0 headers, but am obviously wrong. Here's the list of old
(copyrighted) 2.0 headers:
grep -RL --include=*.java "Licensed to the Apache Software
Foundation (ASF)" * /dev/null
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
Deployment.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
DeploymentException.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
DeploymentFactory.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
DeploymentImpl.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
OpenEJBDeploymentFactory.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
OpenEJBDeploymentManager.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
RemoteServer.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
VmDeploymentFactory.java
container/openejb-core/src/main/java/org/apache/openejb/alt/config/
VmDeploymentManager.java
These are Dain's, we'll let him fix those.
Note, the following don't need/should not have license headers and
won't be updated.
Well, there's interpretation there, of course, but I'd say at least
the xml files should be licensed. The more files licensed, the
easier it is to find offenders in the future... :-)
We can't do that as the xml files themselves are generated (i.e. not
copyrightable) and are there to test that the generated output from
JAXB is good. But I understand what you're saying.
We actually added license headers to them months back when I ran the
RAT tool on the openejb3 codebase. Without thinking I left these
particular xml files in the list and they were all quickly updated
and our build quickly broke :) I had to go and yank them all out.
-David
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/deploy.examples
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/deploy.help
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/start.examples
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/start.help
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/stop.examples
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/stop.help
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/validate.examples
==./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/validate.help
==./container/openejb-core/src/test/resources/openejb-jar.xml
==./container/openejb-jee/src/test/resources/application-client-
example.xml
==./container/openejb-jee/src/test/resources/application-example.xml
==./container/openejb-jee/src/test/resources/ejb-jar-example1.xml
==./container/openejb-jee/src/test/resources/ejb-jar-example2.xml
==./container/openejb-persistence/src/main/java/META-INF/MANIFEST.MF
==./container/openejb-persistence/src/test/resources/persistence-
example.xml
==./itests/openejb-itests-client/src/main/resources/META-INF/
org.openejb.cli/test.help
==./server/openejb-activemq/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/activemq
==./server/openejb-derbynet/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/derbynet
==./server/openejb-ejbd/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/ejbd
==./server/openejb-hsql/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/hsql
==./server/openejb-http/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/httpejbd
==./server/openejb-http/src/test/resources/conf/instantdb.properties
--kevan
