Hi, I was thinking of where to put that code. Thanks for the advice David will do that.
Regards Manu On 4/18/07, David Blevins <[EMAIL PROTECTED]> wrote:
On Apr 17, 2007, at 11:51 AM, Manu George wrote: > Hi, > I just attached a patch to > https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put > together fast. It works (Test Case runs fine). David can you give it a > look and point out any issues. Looks great, Manu! Couple thoughts I had. We should be able to set the MessageContext in the ThreadContext in container's "if (isWebService...)" block which would eliminate the large chunk that seems to do it in the ReflectionInvocationContext. As far as the parameters go I totally forgot to add an assertEquals to verify the bean gets "Hello World" as the arg and is able to return it. We should definitely add that. Feel free to check it in as is then update or update it then check it in, whatever you like. It's good to go! Jarek, thanks for patch OPENEJB-562! Applying it now. Any chance you'll be able to do the JAX-WS version of the JAX-RPC test case? Manu and/or some else might be able to help get that running too. Let us know what your thoughts are. Thanks, David > Regards > Manu > > On 4/17/07, Jacek Laskowski <[EMAIL PROTECTED]> wrote: >> On 4/16/07, Manu George <[EMAIL PROTECTED]> wrote: >> > I would like to volunteer for this task :). Anyone else >> interested to join me ? >> >> I'll surely be watching your steps, but can't commit any time on it >> yet. I'd like to throw some fresh air to the assembly module. >> >> Jacek >> >> -- >> Jacek Laskowski >> http://www.JacekLaskowski.pl >> >
