On Tuesday, 4 September 2018 7:54:55 PM NZST [email protected] wrote: > On Tue, 2018-09-04 at 16:18 +1200, Paul Eggleton wrote: > > In the layer index / RRS code I have found that if it tries to use > > bitbake's git fetcher to access a git repository on github that has > > been renamed or gone private via http/https, I get prompted for a > > password interactively, presumably on the assumption that maybe if I > > authenticate I might be able to see the repo. Here's an example git > > command that will trigger it (trimmed from the actual command issued > > by the fetcher): > > > > git ls-remote http://github.com/symless/synergy.git > > > > This can be disabled by setting the environment variables GIT_ASKPASS > > to an empty string and GIT_TERMINAL_PROMPT to 0, which allows the > > fetch command to fail immediately. I could conceivably do this in the > > layer index / RRS scripts, but it occurred to me that perhaps this > > should be disabled in bitbake's git fetcher itself. We need to decide > > whether or not interactive password prompts should be allowed during > > a fetch operation (I'm guessing not, although I have a feeling this > > might be a "spacebar heating" situation for some). > > > > Thoughts? In particular, does anyone object to disabling such > > interactive prompts during fetching? > > I think this should be disabled in the fetcher. We don't support input > from stdin during builds and this isn't good behaviour. > > stdin tends to be redirected to /dev/null which would cause read errors > but we should also perhaps revisit and check that happens in all the > codepaths. It may be the way the layer index is using the parser code. > Could you check this also happens with that url in a normal build?
So, you're right - if you run bitbake -c checkuri synergy (taking care to ensure PREMIRRORS and MIRRORS are cleared out first) it does fail immediately as it should. As you say, stdin being redirected likely negates the console input (based on the log it doesn't even try), and SSH_ASKPASS not being allowed through into the fetch environment prevents the graphical askpass that is set up in my environment from being triggered, so a bit of a false alarm. I guess I need to do something similar in the two places I call the fetcher within the layer index code. Apologies for the noise! Thanks, Paul -- Paul Eggleton Intel Open Source Technology Centre _______________________________________________ Openembedded-architecture mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-architecture
