On Thu, May 21, 2020 at 10:40 AM Richard Purdie <
[email protected]> wrote:
> On Thu, 2020-05-21 at 09:31 +0100, Richard Purdie
> vialists.openembedded.org wrote:
> > b) to consider whether we should "ban" _remove from YP Compat layers?
> > I know even core has some these days although I have tried very hard
> > not to let them in.
>
> At a quick count, 64 usages in core sadly:
>
I suppose _remove is (ab)used because we can append *only if* an override
is defined. So we are missing a constructor for append if the override is
not defined. e.g.
PACKAGECONFIG_remove_libc-musl = "elf-tls"
to be replaced by
PACKAGECONFIG_append_!lib-musl = "elf-tls"
which is exactly what the _remove statement is trying to express here (and
most likely in most of the _remove use in core). And it would be a more
social behavior.
> meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.3.bb:PACKAGECONFIG_remove_libc-musl
> = "tcp-wrappers"
> meta/recipes-connectivity/dhcp/dhcp.inc:PACKAGES_remove = "${PN}"
> meta/recipes-sato/webkit/webkitgtk_2.28.2.bb:SECURITY_CFLAGS_remove_aarch64
> = "-fpie"
> meta/recipes-sato/images/core-image-sato.bb:TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext
> = " nativesdk-intltool nativesdk-glib-2.0"
> meta/recipes-bsp/gnu-efi/gnu-efi_3.0.12.bb:TUNE_CCARGS_remove =
> "-mfpmath=sse"
> meta/recipes-bsp/grub/grub-efi_2.04.bb:FILES_${PN}_remove_aarch64 =
> "${libdir}/grub/${GRUB_TARGET}-efi"
> meta/recipes-support/boost/boost.inc:BOOST_LIBS_remove_class-native = "
> context coroutine"
> meta/recipes-support/boost/boost.inc:BOOST_LIBS_remove_mips16e = "wave"
> meta/recipes-support/libproxy/libproxy_0.4.15.bb:SECURITY_PIE_CFLAGS_remove
> = "-fPIE -pie"
> meta/recipes-support/vte/vte_0.60.2.bb:PACKAGECONFIG_remove_class-native
> = "vala"
> meta/recipes-extended/asciidoc/asciidoc_8.6.9.bb:RDEPENDS_remove_class-native
> = "python3"
> meta/conf/distro/include/tclibc-newlib.inc:TOOLCHAIN_NEED_CONFIGSITE_CACHE_remove
> = "zlib ncurses"
> meta/conf/distro/include/security_flags.inc:SECURITY_CFLAGS_remove_powerpc
> = "${SECURITY_PIE_CFLAGS}"
> meta/conf/distro/include/tclibc-baremetal.inc:DEPENDS_remove_pn-meta-toolchain
> = "virtual/libc virtual/${TARGET_PREFIX}compilerlibs"
> meta/conf/distro/include/tclibc-baremetal.inc:BASEDEPENDS_remove_class-target
> = "virtual/${TARGET_PREFIX}compilerlibs"
> meta/conf/distro/include/tclibc-baremetal.inc:TOOLCHAIN_NEED_CONFIGSITE_CACHE_remove
> = "virtual/${MLPREFIX}libc zlib ncurses"
> meta/conf/distro/include/ptest-packagelists.inc:PTESTS_SLOW_remove_riscv64
> = "valgrind-ptest"
> meta/conf/distro/include/ptest-packagelists.inc.orig:PTESTS_SLOW_remove_riscv64
> = "valgrind-ptest"
> meta/recipes-devtools/binutils/binutils_2.34.bb:SELECTED_OPTIMIZATION_remove_mipsarch
> = "-O2"
> meta/recipes-devtools/pkgconf/pkgconf_1.6.3.bb:FILES_${PN}-dev_remove =
> "${datadir}/aclocal"
> meta/recipes-devtools/libtool/libtool-2.4.6.inc:FILES_${PN}-dev_remove =
> "${datadir}/aclocal"
> meta/recipes-devtools/opkg-utils/opkg-utils_0.4.2.bb:PACKAGES_remove =
> "${PN}-dev ${PN}-staticdev"
> meta/recipes-devtools/gcc/gcc-runtime.inc:CXXFLAGS_remove =
> "-fvisibility-inlines-hidden"
> meta/recipes-devtools/gcc/gcc-cross-canadian.inc:EXTRA_OECONF_remove_elf =
> "--with-sysroot=/not/exist"
> meta/recipes-devtools/gcc/gcc-cross-canadian.inc:EXTRA_OECONF_remove_eabi
> = "--with-sysroot=/not/exist"
> meta/recipes-devtools/gcc/gcc-cross.inc:EXTRA_OECONF_remove_libc-baremetal
> = "--enable-threads=posix"
> meta/recipes-devtools/gcc/gcc-cross.inc:EXTRA_OECONF_remove_libc-newlib =
> "--enable-threads=posix"
> meta/recipes-devtools/qemu/qemu.inc:PACKAGECONFIG_remove_darwin = "kvm
> virglrenderer glx gtk+"
> meta/recipes-devtools/qemu/qemu.inc:PACKAGECONFIG_remove_mingw32 = "kvm
> virglrenderer glx gtk+"
> meta/recipes-devtools/qemu/qemu-system-native_4.2.0.bb:PACKAGECONFIG_remove
> = "${@'kvm' if not os.path.exists('/usr/include/linux/kvm.h') else ''}"
> meta/recipes-kernel/kexec/kexec-tools_2.0.20.bb:SECURITY_PIE_CFLAGS_remove
> = "-fPIE -pie"
> meta/recipes-kernel/lttng/lttng-tools_2.12.0.bb:PACKAGECONFIG_remove_arc
> = "lttng-ust"
> meta/recipes-kernel/perf/perf.bb:PACKAGECONFIG_remove_arc = "libunwind"
> meta/recipes-kernel/perf/perf.bb:PACKAGECONFIG_remove_riscv64 =
> "libunwind"
> meta/recipes-core/dbus/dbus-test_1.12.16.bb:RDEPENDS_${PN}-ptest_remove =
> "${PN}"
> meta/recipes-core/systemd/systemd-boot_245.5.bb:TUNE_CCARGS_remove =
> "-mfpmath=sse"
> meta/recipes-core/systemd/systemd_245.5.bb:PACKAGECONFIG_remove_libc-musl
> = " \
> meta/recipes-core/glibc/glibc-testsuite_2.31.bb:DEPENDS_remove =
> "libgcc-initial"
> meta/classes/populate_sdk_ext.bbclass:
> f.write('INHERIT_remove = "uninative"\n')
> meta/classes/populate_sdk_ext.bbclass: f.write('INHERIT_remove
> = "%s"\n' % d.getVar('SDK_INHERIT_BLACKLIST', False))
> meta/classes/testimage.bbclass:DEFAULT_TEST_SUITES_remove_aarch64 = "xorg"
> meta/classes/testimage.bbclass:DEFAULT_TEST_SUITES_remove_libc-musl =
> "stap"
> meta/classes/testimage.bbclass:DEFAULT_TEST_SUITES_remove_qemumips =
> "${MIPSREMOVE}"
> meta/classes/testimage.bbclass:DEFAULT_TEST_SUITES_remove_qemumips64 =
> "${MIPSREMOVE}"
> meta/classes/goarch.bbclass:TUNE_CCARGS_remove = "-march=mips32r2"
> meta/classes/update-rc.d.bbclass:PACKAGESPLITFUNCS_remove_class-nativesdk
> = "populate_packages_updatercd "
> meta/recipes-graphics/piglit/piglit_git.bb:SYSROOT_DIRS_remove =
> "${libdir}"
> meta/recipes-graphics/mesa/mesa.inc:PACKAGECONFIG_remove_libc-musl =
> "elf-tls"
> meta/recipes-graphics/xorg-font/font-util_1.3.2.bb:SYSROOT_DIRS_BLACKLIST_remove
> = "${datadir}/fonts"
> meta-selftest/recipes-test/selftest-ed/selftest-ed_0.5.bb:CONFIGUREOPTS_remove
> = "--disable-dependency-tracking"
> meta-selftest/recipes-test/selftest-ed/selftest-ed_0.5.bb:CONFIGUREOPTS_remove
> = "--disable-silent-rules"
> meta-selftest/recipes-test/selftest-ed/selftest-ed_0.5.bb:EXTRA_OECONF_remove
> = "--disable-static"
> meta/lib/oeqa/selftest/cases/sstatetests.py:
> self.append_config('ERROR_QA_remove = "version-going-backwards"')
> meta/lib/oeqa/selftest/cases/sstatetests.py:INHERIT_remove =
> "buildstats-summary buildhistory uninative"
> meta/lib/oeqa/selftest/cases/sstatetests.py:INHERIT_remove = "uninative"
> meta/lib/oeqa/selftest/cases/buildoptions.py:
> self.write_config("INHERIT_remove = \"report-error\"")
> meta/lib/oeqa/selftest/cases/buildoptions.py:
> self.append_config('ERROR_QA_remove = "packages-list"')
> meta/lib/oeqa/selftest/cases/incompatible_lic.py:RDEPENDS_packagegroup-core-full-cmdline-utils_remove
> = "bash bc coreutils cpio ed findutils gawk grep mc mc-fish mc-helpers
> mc-helpers-perl sed tar time"\n
> meta/lib/oeqa/selftest/cases/incompatible_lic.py:RDEPENDS_packagegroup-core-full-cmdline-dev-utils_remove
> = "diffutils m4 make patch"\n
> meta/lib/oeqa/selftest/cases/incompatible_lic.py:RDEPENDS_packagegroup-core-full-cmdline-multiuser_remove
> = "gzip"\n
> meta/lib/oeqa/selftest/cases/lic_checksum.py:
> self.write_config("INHERIT_remove = \"report-error\"")
> meta/lib/oeqa/selftest/cases/bbtests.py:
> self.write_config("INHERIT_remove = \"report-error\"")
> meta/lib/oeqa/selftest/cases/bbtests.py:INHERIT_remove = \"report-error\"
> meta/lib/oeqa/selftest/cases/bbtests.py:INHERIT_remove = \"report-error\"
>
> Cheers,
>
> Richard
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1078):
https://lists.openembedded.org/g/openembedded-architecture/message/1078
Mute This Topic: https://lists.openembedded.org/mt/74369459/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-architecture/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
