On Tue, May 31, 2022 at 7:17 AM Richard Purdie
<[email protected]> wrote:
>
> On Tue, 2022-05-31 at 07:11 -0700, Khem Raj wrote:
> >
> >
> > On Mon, May 30, 2022 at 3:51 AM Richard Purdie
> > <[email protected]> wrote:
> > > I've gone around in circles on this for a long time. The background
> > > isn't obvious at first glance.
> > >
> > > "S" represents where our source is. There is code like do_unpack
> > > which
> > > wants to clean S before rerunning the task. It can't just clean
> > > everything in WORKDIR as there is T, recipe-sysroot* and more that
> > > need
> > > to be left alone (e.g. recipe-sysroot-native may have
> > > do_fetch/do_unpack dependencies).
> > >
> > > S is usually defined as ${BPN}-${PV} via ${BP}.
> > >
> >
> >
> > Maybe disallow workdir to be used as S it’s a rare case anyway. Add a
> > QA check and that
> > Should help recipes to migrate away
>
> It isn't that rare, there are 42 in OE-Core alone.
>
> I do think we should probably migrate away from those though.
I'd vote for that too. I'm sure I've seen other corner cases which
break with S set to WORKDIR (although I forget the details).
It's not trivial to migrate such recipes (since you now need to decide
whether the thing being added to SRC_URI is a source file and so needs
;subdir=${BP} or something which should stay in WORKDIR) but it's not
that hard or disruptive either.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#1558):
https://lists.openembedded.org/g/openembedded-architecture/message/1558
Mute This Topic: https://lists.openembedded.org/mt/91428199/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-architecture/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
