On Fri Jul 24, 2026 at 8:13 AM CEST, Shinu Chandran via lists.openembedded.org 
wrote:
> The recipe currently always inherits mime-xdg and keeps the installed desktop
> files. Add a desktop PACKAGECONFIG option so configurations can disable that
> desktop integration while preserving the current default behavior.
>
> When desktop support is disabled, remove the generated desktop files during
> do_install and avoid inheriting mime-xdg.
>
> Signed-off-by: Shinu Chandran <[email protected]>
> Signed-off-by: Mathieu Dubois-Briand <[email protected]>
> Signed-off-by: Richard Purdie <[email protected]>
> (cherry picked from commit 942813bf3f249f80f3154ba8137d172c406bf319)
> ---
>  meta/recipes-support/vim/vim.inc | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/vim/vim.inc 
> b/meta/recipes-support/vim/vim.inc
> index d69a337b4e..f97062aede 100644
> --- a/meta/recipes-support/vim/vim.inc
> +++ b/meta/recipes-support/vim/vim.inc
> @@ -50,7 +50,7 @@ S = "${WORKDIR}/git"
>  
>  VIMDIR = 
> "vim${@d.getVar('PV').split('.')[0]}${@d.getVar('PV').split('.')[1]}"
>  
> -inherit autotools-brokensep update-alternatives mime-xdg pkgconfig
> +inherit autotools-brokensep update-alternatives pkgconfig
>  
>  CLEANBROKEN = "1"
>  
> @@ -76,9 +76,11 @@ do_configure () {
>  PACKAGECONFIG ??= "\
>      ${@bb.utils.filter('DISTRO_FEATURES', 'acl selinux', d)} \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 gtkgui', '', d)} \
> +    desktop \
>      nls \
>  "

Hello,

Thanks for the patch, but PACKAGECONFIG changes are usually unacceptable
for stable. Are clear bugfix could provide an exception but here I don't
see a "real" bug:
IIUC, using this patch would only cut the dependencies and remove 2
files from the package and this looks more like a cleanup than a real
bugfix.

So, unless you can provide compelling reason to merge this, I won't
accept this for now.

Regards,
-- 
Yoann Congal
Smile ECS

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#244764): 
https://lists.openembedded.org/g/openembedded-core/message/244764
Mute This Topic: https://lists.openembedded.org/mt/120422202/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to