On Wed, Sep 2, 2026 at 1:20 PM Richard Purdie <[email protected]> wrote: > > On Mon, 2026-08-31 at 07:01 +0100, Alex Kiernan via lists.openembedded.org > wrote: > > do_configure built wpa_supplicant's .config by sed-ing upstream's > > defconfig and echoing CONFIG lines onto it, this is both fragile and > > makes handling anything not covered by PACKAGECONFIG tricky. > > > > wpa_supplicant has no configure script and no kconfig - it's just make, > > so switch do_configure to build the configuration from a base file and > > .cfg fragments, which matches what CML1 recipes do (though this isn't > > CML1). > > > > This should have no functional change; the effective configuration > > should be identical. > > > > AI-Generated: Claude Opus 5 (Claude Code) > > Signed-off-by: Alex Kiernan <[email protected]> > > --- > > .../wpa-supplicant/wpa-supplicant/mbo.cfg | 2 + > > .../wpa-supplicant/wpa-supplicant/suiteb.cfg | 4 ++ > > .../wpa-supplicant/tls-gnutls.cfg | 23 ++++++++++ > > .../wpa-supplicant/tls-openssl.cfg | 7 +++ > > .../wpa-supplicant/wpa-supplicant/wnm.cfg | 2 + > > .../wpa-supplicant/wpa-supplicant_2.12.bb | 46 +++++++------------ > > 6 files changed, 55 insertions(+), 29 deletions(-) > > create mode 100644 > > meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/mbo.cfg > > create mode 100644 > > meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/suiteb.cfg > > create mode 100644 > > meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/tls-gnutls.cfg > > create mode 100644 > > meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/tls-openssl.cfg > > create mode 100644 > > meta/recipes-connectivity/wpa-supplicant/wpa-supplicant/wnm.cfg > > I'm not convinced this is an improvement. It takes one relatively > readable function and turns it into many different files spread all > over and complicates the SRC_URI. > > I appreciate it isn't easy to add new entries currently but that could > be solved by making this function a standalone function which a > bbappend could add to, if the additional PACKAGECONFIG really isn't > suitable for core. >
Okay, I can do that instead... what really bit me was the need to replace the whole config and then having override the entire do_configure in order to stop it modifying it. -- Alex Kiernan
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#244945): https://lists.openembedded.org/g/openembedded-core/message/244945 Mute This Topic: https://lists.openembedded.org/mt/121009603/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
