On Thu, Sep 10, 2026 at 7:07 AM 전민지 via lists.openembedded.org <emzei.j=
[email protected]> wrote:
>
>
> Hello,
>
> While investigating SPDX 3.0 annotation generation on the scarthgap
> branch, I noticed a difference between scarthgap and master in how
> SPDX_CUSTOM_ANNOTATION_VARS is handled in spdx30_tasks.py.
>
> In scarthgap (meta/lib/oe/spdx30_tasks.py, around line 520):
>
> new_annotation(
> d,
> build_objset,
> build,
> "%s=%s" % (var, d.getVar(var)),
> oe.spdx30.AnnotationType.other,
> )
>
> In master (meta/lib/oe/spdx30_tasks.py, around line 549):
>
> objset.new_annotation(
> build,
> "%s=%s" % (var, d.getVar(var)),
> oe.spdx30.AnnotationType.other,
> )
>
> When SPDX_CUSTOM_ANNOTATION_VARS is set on scarthgap, do_create_spdx
> fails with:
>
> Exception: NameError: name 'new_annotation' is not defined
>
> The failure occurs at meta/lib/oe/spdx30_tasks.py:520 while processing
> SPDX_CUSTOM_ANNOTATION_VARS.
>
> I could not determine whether this difference is intentional or whether
> the corresponding fix was missed when changes were backported to scarthgap.
>
It was unintentional. The correct fix is to backport:
52ab3b640c ("spdx30_tasks: Fix SPDX_CUSTOM_ANNOTATION_VARS implementation")
to scarthgap. It probably happened because the ordering of the backport to
scarthgap and the bug fix caused it to be missed, but I did not verify that.
>
> Would it be appropriate to backport the master implementation to scarthgap?
>
> Thanks,
> Minji Jeon
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#245604):
https://lists.openembedded.org/g/openembedded-core/message/245604
Mute This Topic: https://lists.openembedded.org/mt/121179868/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
