Hello Otavio Salvador, Thank you for your comments. I had submitted patch v3 . Please review them .
Thanks Chunrong -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Otavio Salvador Sent: Tuesday, December 02, 2014 8:43 PM To: Guo Chunrong-B40290 Cc: Patches and discussions about the oe-core layer Subject: Re: [OE-core] [PATCH v2 2/2] u-boot.inc : add compile multiple u-boot feature Hello Chunrong, On Mon, Nov 24, 2014 at 3:24 AM, Chunrong Guo <[email protected]> wrote: > Signed-off-by: Chunrong Guo <[email protected]> > --- > meta/recipes-bsp/u-boot/u-boot.inc | 56 > +++++++++++++++++++++----------------- > 1 file changed, 31 insertions(+), 25 deletions(-) > > diff --git a/meta/recipes-bsp/u-boot/u-boot.inc > b/meta/recipes-bsp/u-boot/u-boot.inc > index c695b73..bd76241 100644 > --- a/meta/recipes-bsp/u-boot/u-boot.inc > +++ b/meta/recipes-bsp/u-boot/u-boot.inc > @@ -63,25 +63,32 @@ do_compile () { > echo ${UBOOT_LOCALVERSION} > ${S}/.scmversion > fi > > - oe_runmake ${UBOOT_MACHINE} > - oe_runmake ${UBOOT_MAKE_TARGET} > + for type in ${UBOOT_MACHINE}; do > + oe_runmake O=${type} ${type} > + oe_runmake O=${type} ${UBOOT_MAKE_TARGET} > + cp ${S}/${type}/${UBOOT_BINARY} ${S}/${type}/u-boot-${type}.bin > + done > + > } The out of tree build has caused some headache in one of our internal customer layers; it was indeed caused by a "bug" in the respective recipe but I think it is worth mention that it now builds using out of tree in the commit log so people are aware. There are two things which has catch my attention here: * filename uglyness: the filename in deploy dir is using the UBOOT_MACHINE however the UBOOT_CONFIG 'name' would be better as it is more meaningful. * difficulty to figure the binary when generating the rootfs: in meta-fsl-arm, for example, we generate the .sdcard rootfs and using the patch we now have... ERROR: Error: The image creation script '.../tmp/work/imx6qsabresd-oel-linux-gnueabi/core-image-minimal/1.0-r0/temp/create_image.sdcard' returned 1: 0+0 records in 0+0 records out 0 bytes (0 B) copied, 1.3395e-05 s, 0.0 kB/s Model: (file) Disk .../tmp/deploy/images/imx6qsabresd/core-image-minimal-imx6qsabresd-20141202123437.rootfs.sdcard: 67.1MB Sector size (logical/physical): 512B/512B Partition Table: msdos Disk Flags: Number Start End Size Type File system Flags 1 4194kB 12.6MB 8389kB primary lba 2 12.6MB 62.9MB 50.3MB primary dd: opening `.../tmp/deploy/images/imx6qsabresd/u-boot-imx6qsabresd.imx': No such file or directory WARNING: .../tmp/work/imx6qsabresd-oel-linux-gnueabi/core-image-minimal/1.0-r0/temp/create_image.sdcard:1 exit 1 from dd if=.../tmp/deploy/images/imx6qsabresd/u-boot-imx6qsabresd.imx of=.../tmp/deploy/images/imx6qsabresd/core-image-minimal-imx6qsabresd-20141202123437.rootfs.sdcard conv=notrunc seek=2 skip=0 bs=512 ERROR: Function failed: do_rootfs ERROR: Logfile of failure stored in: .../tmp/work/imx6qsabresd-oel-linux-gnueabi/core-image-minimal/1.0-r0/temp/log.do_rootfs.31415 ERROR: Task 7 (.../poky/meta/recipes-core/images/core-image-minimal.bb, do_rootfs) failed with exit code '1' Do you have any idea how we could address those issues? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
