On 5/17/11 9:35 AM, Richard Purdie wrote:
> On Tue, 2011-05-17 at 15:17 +0100, Phil Blundell wrote:
>> Signed-off-by: Phil Blundell <[email protected]>
>> ---
>> meta/classes/image-prelink.bbclass | 13 +++++--------
>> 1 files changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/meta/classes/image-prelink.bbclass
>> b/meta/classes/image-prelink.bbclass
>> index ee0951c..350c29d 100644
>> --- a/meta/classes/image-prelink.bbclass
>> +++ b/meta/classes/image-prelink.bbclass
...
>> # prelink!
>> - ${STAGING_DIR_NATIVE}/usr/sbin/prelink --root ${IMAGE_ROOTFS} -amR
>> + ${STAGING_DIR_NATIVE}${sbindir_native}/prelink --root ${IMAGE_ROOTFS}
>> -amR -N -c ${sysconfdir}/prelink.conf
...
>>
>> - # Cleanup temporary file, it's not needed...
>> - rm -f ${IMAGE_ROOTFS}/etc/prelink.cache
>> -
>
> The patch description and what it does don't quite match (the rm is
> removed and options are added to prelink).
I agree the commit message needs some more description. Just as an FYI. The -N
option causes the prelinker to not generate/save the cache file. While the -c
tells it to read a specific .conf file.
So the actual code changes are good, the description is the only thing that
needs to be improved, so someone not familiar with the prelinker can understand
the change.
--Mark
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> [email protected]
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
