Phil Blundell wrote on 2011-05-26:
> On Thu, 2011-05-26 at 19:55 +0800, Lianhao Lu wrote:
>> -EXTENDPV = "${EXTENDPEVER}${PV}-${PR}"
>> +EXTENDPV = "${EXTENDPEVER}${PV}-${PKGR}"
>
> That looks a bit weird. Is it really correct to be mixing PV and PKGR like
> that?
>
> FWIW, oe master has:
>
> EXTENDPE = "${@int('${PE}') and '${PE}_' or ''}"
> EXTENDPEVER = "${@int('${PE}') and '${PE}:' or ''}"
> EXTENDPV = "${EXTENDPEVER}${PV}-${PR}${DISTRO_PR}"
>
> PKGV ?= "${PV}"
> PKGR ?= "${PR}${DISTRO_PR}"
>
> EXTENDPKGEVER = "${@['','${PKGE\x7d:'][bb.data.getVar('PKGE',d,1) > 0]}"
> EXTENDPKGV ?= "${EXTENDPKGEVER}${PKGV}-${PKGR}"
>
> and, although there are a couple of uses of ${EXTENDPV} that should
> perhaps be ${EXTENDPKGV}, this arrangement seems sensible otherwise.
>
The problem is that in OE-core the default -deb/-dbg packages are all using
EXTENDPV, as well as some other recipes. Do you mean we should make them all
using EXTENDPKGV instead of EXTENDPV? If this is the way, I think PKGE should
be used instead of PE in package_xxx.bbclass, though currently I don't see any
recipe in OE using PKGE, but some of them do use PE.
Best Regards,
Lianhao
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
