On Fri, Jul 8, 2011 at 5:38 PM, Darren Hart <[email protected]> wrote: > > > On 07/07/2011 04:11 PM, Andrea Adami wrote: >> * from org.openembedded.dev (oe-classic) > > Hi Andrea, > > Please include a descriptive blurb about the patch. When people read > through the commit log they need to know what problem this patch > addresses and how it intends to go about it. If possible, it should also > include the commit id from the source (I suspect that isn't an option here). > Well, there isn't really much to say: whether you know what an initramfs is or not :) Seriously, about the history of the patch, there have been so many commits that I could not choose one. See next comment.
> > Hrm... Why is this part of do_configure? Seems a lot more like a deploy > or install step. If you look at the history at http://cgit.openembedded.org/cgit.cgi/openembedded/log/classes/kernel.bbclass?h=org.openembedded.dev&ofs=50 you'll discover that there was a separate task (72761e4) which has been unified by the author as of commit 3e3f297. After some rounds of fixes, the code was moved in do_configure with commit id fc03e2b (kernel.bbclass: move initramfs stuff to configure so we can do postprocessing on it with do_configure_append). >Also, the cp line has been truncated here. The original patch sent by git send.email should be sane. > -- > Darren Hart > Intel Open Source Technology Center > Yocto Project - Linux Kernel > Regards Andrea _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
